Three fixes found for ESP32-C6#9616
Merged
Merged
Conversation
Espressif's Characteristics allocate memory that may be on the supervisor heap. We need to free it when stopping BLE workflow. Otherwise, we leak the memory and eventually safe mode. Fixes micropython#9599
The BLE workflow was allocating to the VM heap when it wasn't active and causing a port_malloc.
Some serial sources clear their RX buffers and others didn't. This cause CP to skip into the REPL based on characters typed before the CTRL-C. The serial file transfer code looks for "press any key" which is skipped in this case. Fixes circuitpython/web-editor#238
This was
linked to
issues
Sep 12, 2024
dhalbert
approved these changes
Sep 12, 2024
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
Lots of interrelated fixes. Thanks for the debugging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_bleio.Characteristicby addingdeinit().gc_alloc_possible()because it was true after the first VM run and caused BLE characteristic allocations outside the VM to occur on the VM heap.