Fix always zero AnalogIn on nordic#9114
Merged
Merged
Conversation
dhalbert
force-pushed
the
fix-nordic-analogin
branch
from
March 29, 2024 02:10
d7df835 to
1821a7a
Compare
dhalbert
force-pushed
the
fix-nordic-analogin
branch
from
March 29, 2024 02:26
1821a7a to
453c82c
Compare
tannewt
requested changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is quite mysterious. The underlying code hasn't changed in quite a while. nordic
AnalogIn.valuewas always returning zero on 9.x.x builds, including some early betas. The problem starts appearing when gcc13 starts being used. Compiling with gcc10 or gcc12 causes the problem to go away.While debugging, I added a printf which also caused the problem to go away. Adding tiny delay calls almost anywhere also helped. Eventually I realized it may have been due to these calls acting as an optimization memory fence. Adding
asm volatile("": : : "memory");had the same effect. I'm not sure whether this is a compiler bug or something else, but the fix works.Also removed the logic to start with
value = -1, which didn't seem necessary.