Require explicit socket port reuse#8940
Merged
Merged
Conversation
Doing it implicitly can lead to mistaken socket leaks and reuse. It now matches CPython. Fixes micropython#8443
|
dhalbert
approved these changes
Feb 17, 2024
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
I am going to merge this, but will mention in the release notes that this is a breaking change and mention socket.setsockopt(pool.SOL_SOCKET, pool.SO_REUSEADDR, 1)
Member
|
just for completeness of this thread... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing it implicitly can lead to mistaken socket leaks and reuse. It now matches CPython.
Fixes #8443