Pimoroni Pico DV Base W: Fix I2S Audio Assignments#8915
Merged
Conversation
dhalbert
approved these changes
Feb 14, 2024
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making this consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pimoroni Pico DV Base W wasn't included in CP until 9.x, I guess I could have added it to the last 8.2.x PR but I didn't think of that until just now. In any case this performs the same I2S audio pin fix that #8906 did for the non-wireless version of the Pico DV Base.