Fix bugs exposed by posix port#8900
Merged
Merged
Conversation
tannewt
requested changes
Feb 12, 2024
tannewt
left a comment
Member
There was a problem hiding this comment.
Is the random bits 0 behavior change to match CPython?
Member
|
Why don't we update black in #8906 and then merge that into main? |
Author
|
I'm fine with rebasing this once #8906 is merged, if that makes sense to you. |
Member
|
Ok, merged in #8912 |
this is defined by python (returns 0) and tested in a test
These were used with an earlier iteration of the camera, but are not used now. (removed from build at d1b89fc)
Author
|
rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on some experimental code ("posix port") I found some bugs & build problems.
The added includes are to get structure definitions and/or function prototypes for things that are included indirectly only when certain other features are enabled, which is why the problems weren't seen before.
The removed includes are for stuff not yet implemented on the POSIX port, where the include was apparently copied as boilerplate and is not actually needed.