raspberrypi: Make port_idle_until_interrupt work#7201
Merged
Conversation
This needs thorough testing before it's merged, as we tried and reverted this once before (adafruit#5341 and adafruit#5356). I think that besides checking for tinyusb having "something to do", the fact that `port_interrupt_after_ticks` and `port_disable_tick` weren't implemented that was causing a secondary problem. I've tested this on a pico w over reboot-cycles and ctrl-c-cycles, with and without drive automounting, with and without serial repl open, and on a power-only connection. I didn't notice the problem reported in adafruit#5356 after merely implementing port_idle_until_interrupt; but I did notice that sleeps in general would take over-long until "something" (like writing to the USB drive) happened; I think "something" was probably calling port_enable_tick(). When this problem was happening, sleeps would take a lot longer; for instance, `sleep(.001)` would take about 1/20s and `sleep(.1)` would take about 1/7s.
Author
|
@Neradoc @microdev1 @urish if any of you have time & interest in testing out this branch it would be helpful! |
|
What kind of help do you need w/testing? |
Author
|
Just general testing, as the earlier occasion when we tried to enable WFI for light sleeping problems cropped up that the original submitter didn't find right away. I tried to test a number of scenarios that would "cover" normal usage but one always misses something... |
Member
|
This looks fine to me. I'm happy to test in |
tannewt
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs thorough testing before it's merged, as we tried and reverted this once before (#5341 and #5356).
I think that besides checking for tinyusb having "something to do", the fact that
port_interrupt_after_ticksandport_disable_tickweren't implemented that was causing a secondary problem.I've tested this on a pico w over reboot-cycles and ctrl-c-cycles, with and without drive automounting, with and without serial repl open, and on a power-only connection.
I didn't notice the problem reported in #5356 after merely implementing port_idle_until_interrupt; but I did notice that sleeps in general would take over-long until "something" (like writing to the USB drive) happened; I think "something" was probably calling port_enable_tick(). When this problem was happening, sleeps would take a lot longer; for instance,
sleep(.001)would take about 1/20s andsleep(.1)would take about 1/7s.Closes: #5331