esp32s3-box: enable display#5674
Merged
Merged
Conversation
Author
|
Note that trying to use this LCD with |
tannewt
approved these changes
Dec 6, 2021
tannewt
left a comment
Member
There was a problem hiding this comment.
Thanks for getting this going!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This involves also fixing some problems with pin & pwm busy & never-reset tracking.
Before these changes, the PWM created during
board_init()was lost, making the display not appear (backlight turned full off).Now, the display is initialized at boot time and all the related pins remain allocated as far as attempts to construct a
DigitalInOutusing them are concerned.@dhalbert wondered whether this could be related to #5476 but as the fixes I found were entirely within the port, it seems less likely there is a shared cause with that other issue, affecting samd microcontrollers. (which is not to say there might not be similar bugs in two ports)