Skip to content

Fix central pairing and crash on clear#4522

Merged
dhalbert merged 1 commit into
adafruit:mainfrom
tannewt:ble_fixup
Apr 1, 2021
Merged

Fix central pairing and crash on clear#4522
dhalbert merged 1 commit into
adafruit:mainfrom
tannewt:ble_fixup

Conversation

@tannewt

@tannewt tannewt commented Mar 31, 2021

Copy link
Copy Markdown
Member

The list_clear would crash if we tried to clear a NULL list. (It
can happen if we haven't tried to discover any services.)

The list_clear would crash if we tried to clear a NULL list. (It
can happen if we haven't tried to discover any services.)

@dhalbert dhalbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and central service discovery tests out OK. The discovery thing basically finishes off #3228 properly; that code looked pretty familiar.

@dhalbert dhalbert merged commit d0ba75e into adafruit:main Apr 1, 2021
@dhalbert

dhalbert commented Apr 1, 2021

Copy link
Copy Markdown
Collaborator

@tannewt This does not contain any PacketBuffer-specific fixes. Were you referring to this PR in adafruit/Adafruit_CircuitPython_BLE#91 (comment) ?

@tannewt

tannewt commented Apr 1, 2021

Copy link
Copy Markdown
Member Author

@dhalbert Nope, I haven't pushed the packet buffer fixes yet and ya, those fixes were what I was referring to. Will push them this afternoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants