Feathers2 nsync#3914
Merged
Merged
Conversation
Author
|
I'm up for cleaning up the commit history, but the changes are just what were expected. Ready for Review. |
Member
|
@UnexpectedMaker please take a look! |
UnexpectedMaker
suggested changes
Jan 2, 2021
UnexpectedMaker
left a comment
There was a problem hiding this comment.
Thanks for doing this @askpatrickw
IO13 is still in pins.c twice for FeatherS2 and Prerelease - lines 93 & 12
Please remove lines 93 in both files
Cheers
Seon
Author
|
@UnexpectedMaker This last commit fixes that dupe IO13 and removes some whitespace. |
UnexpectedMaker
approved these changes
Jan 3, 2021
There was a problem hiding this comment.
I just found out why IO13 was in there twice. One was supposed to be IO14 - Seems I have an incorrect label on my silk and pinout card.
@tannewt Can this please be merged, so I can fix the IO13/IO14 issue for the next update?
Thanks :)
ladyada
approved these changes
Jan 3, 2021
|
Thanks @ladyada :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is draft because I'm not sure of the commits from pull cp/main.
The changes though are to being the FeatherS2 files NSync with the only changes being the actual changes between the two boards.
I have tested board.I2C() works on the pre-release.