Skip to content

esp32s2: don't delete the event loop#3716

Merged
tannewt merged 2 commits into
adafruit:mainfrom
jepler:keep-event-loop
Nov 19, 2020
Merged

esp32s2: don't delete the event loop#3716
tannewt merged 2 commits into
adafruit:mainfrom
jepler:keep-event-loop

Conversation

@jepler

@jepler jepler commented Nov 18, 2020

Copy link
Copy Markdown

.. it seems to make the esp-idf grumpy.

.. it seems to make the esp-idf grumpy.
@jepler

jepler commented Nov 18, 2020

Copy link
Copy Markdown
Author

This was to avoid an error in debug builds but the cure is worse than the disease.

esp_err_t esp_event_loop_create_default(void)
{
    if (s_default_loop) {
        return ESP_ERR_INVALID_STATE;
    }

@tannewt

tannewt commented Nov 18, 2020

Copy link
Copy Markdown
Member

How about tracking if netif has been started once and only get the loop when it hasn't been?

deinitting these seems to cause problems.

@tannewt tannewt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants