esp32s2: wifi: fix several debug-build errors#3689
Merged
Conversation
Closes adafruit#3688 With this change, I don't get the ESP_ERROR_CHECK failed repeatedly running code that imports wifi. (I'm not getting a successful connection but that's probably my own fault, such as a secrets problem)
Author
|
Testing performed: In a debug build on kaluga, repeatedly ran a test program which does There's more code after "..." but for probably unrelated reasons my wifi connection doesn't actually succeed. |
Author
|
With this something else is still wrong with my debug builds -- adding DEBUG=1 to the Make environment AND making the following changes in ... leads to non-working wifi |
Member
|
So... do you want to merge it or not? |
Author
|
I don't think it's causing the wifi failures I saw with the additional debug flags enabled, so yeah, I'd like to see it merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3688
With this change, I don't get the ESP_ERROR_CHECK failed repeatedly running code that imports wifi. (I'm not getting a successful connection but that's probably my own fault, such as a secrets problem)