atmel-samd: parallelize lto linking#3541
Merged
Merged
Conversation
Author
|
A curious error on two builds: I'll investigate. |
Member
|
I don't think we want to increase the binary size at all. #3529 is currently failing due to running out of space on the French translation for the metro_m0_express. |
Author
|
@tannewt I hope I can still get this to the point of being possible to include; but if not, we should grab the parts that fix comparisons against pin objects that don't actually exist, like 051e7d5 -- and pull in the related submodule update adafruit/samd-peripherals#37 which will turn such mistakes into compile-time errors. |
This decreases the link time, especially on desktop machines with many CPU cores. However, it does come at a slight cost in binary size, making the flash section about 200 bytes bigger for circuitplayground_express. Before, linking build-circuitplayground_express/firmware.elf takes 8.8s elapsed time, leaving 3128 bytes free in flash. After, linking build-circuitplayground_express/firmware.elf takes 2.8s elapsed time, leaving 2924 bytes free in flash. (-6 seconds, -204 bytes free) If necessary, we can make this per-board or even per-translation to squeeze full builds.
.. when PA30 is IGNOREd
this is possible now that the undefined reference to pin_PA30 has been resolved.
The SDA, SCL, and MISO pins were ignored. This error was not diagnosed before now.
tannewt
approved these changes
Oct 19, 2020
tannewt
left a comment
Member
There was a problem hiding this comment.
This looks good! Beware, I'll be tempted to set lto back to a single partition when we need the space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This decreases the link time, especially on desktop machines with many CPU
cores. However, it does come at a slight cost in binary size, making the flash
section about 200 bytes bigger for circuitplayground_express.
Before, linking build-circuitplayground_express/firmware.elf takes
8.8s elapsed time, leaving 3128 bytes free in flash.
After, linking build-circuitplayground_express/firmware.elf takes 2.8s elapsed
time, leaving 2924 bytes free in flash. (-6 seconds, -204 bytes free)
If necessary, we can make this per-board or even per-translation to squeeze full
builds.