Add .hidden to TileGrid and Group#2113
Merged
Merged
Conversation
This allows for one to preserve ordering within a Group while hiding something temporarily. Fixes micropython#1688
Member
|
yayy |
dhalbert
previously approved these changes
Sep 4, 2019
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
Will approve without the bool:1 changes if you want.
I did some gedanken experiments about hiding and unhiding nested objects in odd orders, and I wasn't able to generate inconsistent states. Looks good!
Member
Author
|
@dhalbert Done and done. |
Member
Author
|
Ok, @dhalbert this passes all of the checks now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for one to preserve ordering within a Group while
hiding something temporarily.
Fixes #1688