Clock the SAMD21 much faster so it can actually convert at its max#1202
Merged
Conversation
sample rate of 350ksps. Also added an error check of sample rate. Fixes micropython#1196
ATMakersBill
left a comment
Collaborator
There was a problem hiding this comment.
I don't think I count as a reviewer with write access, but I pulled Scott's code, built it, ran it on the CPX that failed with the current 3.0 build and his fix worked.
dhalbert
approved these changes
Sep 19, 2018
Collaborator
There was a problem hiding this comment.
I see: ugh, bad datasheet. There's a discussion (in German) about this: https://translate.google.com/translate?hl=en&sl=de&u=https://www.mikrocontroller.net/topic/433420&prev=search
which says 48Mhz is fine.
Do you have another reference as well?
I added a comment here:
https://community.atmel.com/forum/samd11-dac-speed-problem
Member
Author
|
I couldn't find a reference. I just tried it and verified with the Saleae. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sample rate of 350ksps.
Also added an error check of sample rate.
Fixes #1196