Repository navigation
test: include error detail in token revocation failure test - #405
Draft
parkerbxyz with Copilot wants to merge 4 commits into
Draft
parkerbxyz with Copilot wants to merge 4 commits into
parkerbxyz with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: parkerbxyz <17183625+parkerbxyz@users.noreply.github.com>
Revert the redundant redaction in lib/post.js; the token is already masked via core.setSecret in main. The empty warning came from the mocked 401 response having no body, so give it one instead. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61859778-5e53-432d-864c-8eddd0375f86
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61859778-5e53-432d-864c-8eddd0375f86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
post-revoke-token-fail-responsesnapshot showedToken revocation failed:with nothing after the colon.lib/post.jsalready includeserror.message, but the mocked 401 response had no body, so the message was empty.Because of that, the snapshot couldn't tell whether the warning included the error. If someone removed
${error.message}, the test would still pass.This PR gives the mocked 401 a
Bad credentialsbody, which is closer to what GitHub returns for a bad token. The snapshot now asserts:I checked this by temporarily removing
${error.message}fromlib/post.js, and the test failed as expected.No source changes are needed.
mainalready masks the token withcore.setSecret, so the runner redacts it in the post step.