Repository navigation
Handle repositories input with spaces between repositories #106
Description
This action could handle a little more flexibility in the repositories input. A common mistake is to provide repositories: foo, bar instead of repositories: foo,bar if a token is needed for > 1 repository.
For example:
- name: Generate Github Actions App token
id: generate-token
uses: actions/create-github-app-token@v1
with:
app-id: ${{ env.GH_APP_APP_ID }}
private-key: ${{ env.GH_APP_PRIVATE_KEY }}
repositories: foo, barFails to get a token because the body in the HTTP request to GH will look like this:
body: '{"repositories":["foo"," bar"]}',
I think trimming the repos, something like repos = repos.map(r => r.trim()), would catch this and make for a more intuitive API
Activity
gr2m commentedon Feb 27, 2024
Yes, we should definitely do that. Pull request welcome! Please add a test or update one of the existing ones 🙏
krokofant commentedon Jun 3, 2024
Should trailing commas be trimmed as well? Seems these lines needs to be changed
create-github-app-token/lib/main.js
Line 147 in c8f55ef
create-github-app-token/lib/main.js
Line 157 in c8f55ef
For just spaces
With trailing commas:
create-app-token-action-releaser commentedon Sep 11, 2024
🎉 This issue has been resolved in version 1.11.0 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
feat: allow repositories input to be comma or newline-separated (#169)