Skip to content

Remove call.without.effects intrinsic #9399

Open

Description

@stevenfontanella

Binaryen exposes a call.without.effects intrinsic that indicates that the underlying function call can be assumed to have no effects and thus can be e.g. removed if its return value isn't demanded. This intrinsic has since been subsumed by the annotations @binaryen.removable.if.unused and @binaryen.idempotent. In addition, call.without.effects has an awkward representation in our IR which has caused some bugs (#8693, #9393, #9404), and requires special handling by several passes, which in many cases aren't interested in the actual effects, but just need extra introspection to find the actual function being called: link (#9393 is an example of this).

We should remove the intrinsic once toolchains aren't making use of it anymore.


call.without.effects doesn't correspond exactly to either of @binaryen.removable.if.unused or @binaryen.idempotent. call.without.effects does imply removable.if.unused, however it does not imply idempotent, because call.without.effects calls may still be generative (i.e. they may allocate), in which case the calls are not idempotent. When migrating, @binaryen.removable.if.unused can be safely inserted but @binaryen.idempotent needs to be considered on a case-by-case basis.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions