Fixed missing flag in HelloCube#270
Merged
Merged
Conversation
Fixed "NonUniformScale" flag missing from GetEntity call in RotationSpeedAuthoring for the HelloCube tutorial. The example runs without it due to the cube in the example scene being non-uniform and therefore gaining PostTransformMatrix, but will cause hard-to-debug issues for anyone recreating the code in the tutorial.
Contributor
|
If you modify the transform in the editor, baking should add PostTransformMatrix, but I suppose it can be a problem if you set scale at runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed "NonUniformScale" flag missing from GetEntity call in RotationSpeedAuthoring for the HelloCube tutorial.
The example runs without it due to the cube in the example scene being non-uniform and therefore gaining PostTransformMatrix, but will cause hard-to-debug issues for anyone recreating the code in the tutorial.