Skip to content

Cleanup from recent changes#1647

Merged
rahul-malik merged 2 commits into
masterfrom
rmalik/pr-cleanup
Aug 28, 2019
Merged

Cleanup from recent changes#1647
rahul-malik merged 2 commits into
masterfrom
rmalik/pr-cleanup

Conversation

@rahul-malik

Copy link
Copy Markdown
Contributor
  • Fix availability warnings for usage of userInterfaceLevel
  • Deprecate asyncTraitCollectionDidChange in favor of the new method
  • Remove old compiler warning flag added for Xcode 9 compilation
  • Access textColorFollowsTintColor with a locked scope

- Fix availability warnings for usage of userInterfaceLevel
- Deprecate `asyncTraitCollectionDidChange` in favor of the new method
- Remove old compiler warning flag added for Xcode 9 building
- Access `textColorFollowsTintColor` with a locked scope
Comment thread Source/ASImageNode.mm Outdated
Comment thread Source/Base/ASBaseDefines.h
@mikezucc

Copy link
Copy Markdown
Contributor

Will this break other devs on lower Xcodes? or should we expect them all to upgrade?

@bolsinga bolsinga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it would be terrific to know more about tvos stuff, but I don't know.

@rahul-malik

Copy link
Copy Markdown
Contributor Author

@bolsinga @mikezucc - tvOS example project added here #1649

@rahul-malik rahul-malik merged commit 6464153 into master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants