Repository navigation
[Feature Request]: Optimize _match_missing_file #610
Description
Activity
- added a commit that references this issue
on Nov 28, 2024 I would call this more of a request/need for optimization than a bug since the code is working as intended, but I do agree that this area of the code could really use some optimizing.
Between feature request and bug, I felt like "doesn't work as it should" fit better than "doesn't work like how I want"
There's no clear category for where to put performance issues over stuff that actually breaks something :^)Reacted by Travis Abendshien and Poseidon- added a commit that references this issue
on Nov 29, 2024 - changed the title
[-][Bug]: _match_missing_file walks library for every missing file[/-][+][Feature Request]: Optimize _match_missing_file[/+]on Dec 5, 2024 Hi @CyanVoxel for auto-relink of files on rename or moved files, we can have...
- a prefix in the filename like id of file in DB (drawbacks - if user removes the prefix, then manual linking is needed)
- hash value of file (drawbacks - if file is edited then hash value will change and manual linking is needed)
- combination of both prefix id & hash value for auto-relink, incase user mistakenly deleted the prefix , then the program can rename the file & add prefix, based on the hash match (drawbacks - file with same hash/duplicate files)
Checklist
TagStudio Version
Alpha 9.4.0+
Operating System & Version
NixOS unstable
Description
the Search & Relink feature for missing files is incredibly slow for larger libraries, since for every missing entry it walks the library directory again. Extremely noticeable on larger library.
(I noticed this when reorganizing my photos folder from
YYYY/folders toYYYY/MM/DD/folders, so there were ~11000 moved files)Expected Behavior
The list of files in the library should be cached between calls to _match_missing_file to speed up unlinked entry Relinking.
In a bodge solution I added a simple member
_cacheto the Library class, and in _match_missing_file initialize it with the result of os.walk, if not already set.Steps to Reproduce
Logs
No response