Skip to content

fix(ci): run release-pr on the runner's Node - #1744

Merged
Oskar Haarklou Veileborg (BarrensZeppelin) merged 1 commit into
v1.xfrom
fix/release-pr-node-install
Nov 19, 2026
Merged

Oskar Haarklou Veileborg (BarrensZeppelin) merged 1 commit into
v1.xfrom
fix/release-pr-node-install

Conversation

@BarrensZeppelin

Copy link
Copy Markdown
Member

The mode: release-pr dispatch of the publish workflow fails in the "Open the release PR" job with pnpm: command not found (run).

That job reuses the shared &install-node step, which #1736 switched from node scripts/ci/setup-node.mjs to pnpm run ci:setup-node. The job deliberately installs no pnpm because it holds the release App token, so the step can no longer run there.

This drops the Node install from release-pr instead. The pin no longer buys anything in that job:

  • The setup script is now .mts, so the runner's Node must already strip types before the pinned install could run. The pin used to guarantee that; it no longer can.
  • mint-app-token.mjs and open-release-pr.mts (and its imports) use only node: builtins.
  • The ubuntu-latest image the job ran on (ubuntu-26.04, 20261111.196) ships Node 24.22.2. Locally, both scripts load and answer --help on Node 22.18.0, 24.22.1 and 24.22.3, and test/release-open-pr.test.mts plus test/release-workflow.test.mts pass on 24.22.1.

The job now installs nothing, which matches its comment. The shared step stays as #1736 left it for verify and prepare, which install pnpm first.

After merge, re-dispatch with mode: release-pr and dry-run: false. That run is the real test, since nothing local exercises the GitHub API calls.

Expected reviewer effort: Stamp

The release-pr job reused the shared install-node step, which #1736
switched to `pnpm run ci:setup-node`. The job deliberately installs no
pnpm because it holds the release App token, so the step failed with
"pnpm: command not found" and no release PR could be opened.

The job does not need a pinned Node. Its scripts use only node:
builtins, and the setup script is itself .mts, so the runner's Node
already has to strip types before the pinned install could even run.
Dropping the step leaves the job installing nothing.
@cursor

cursor Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Workflow-only change to a job that already skips dependency install; bounded to release PR automation with no app runtime impact.

Overview
Fixes mode: release-pr failing in Open the release PR with pnpm: command not found after the shared Install Node.js step was changed to run pnpm run ci:setup-node.

That job is intentionally pnpm-free (it holds the release App token), so it no longer includes the shared *install-node anchor. verify and prepare still install pnpm and keep the pinned Node setup.

Mint release App token and Commit the bump and open the release PR now use the ubuntu-latest image's built-in Node, which is enough for the release scripts that only rely on node: builtins.

Reviewed by Cursor Bugbot for commit edea205. Configure here.

@BarrensZeppelin
Oskar Haarklou Veileborg (BarrensZeppelin) merged commit de9f6c6 into v1.x Nov 19, 2026
26 checks passed
@BarrensZeppelin
Oskar Haarklou Veileborg (BarrensZeppelin) deleted the fix/release-pr-node-install branch November 19, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants