Skip to content

refactor: follow-ups to generating Socket facts with Coana - #1733

Draft
Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 2 commits into
jfblaa/facts-5-wizardsfrom
jfblaa/facts-6-follow-ups
Draft

Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 2 commits into
jfblaa/facts-5-wizardsfrom
jfblaa/facts-6-follow-ups

Conversation

@jfblaa

@jfblaa Jeppe Fredsgaard Blaabjerg (jfblaa) commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Heads up, reviewer

[Edit me, human!]


LLM Description written by Claude Code:claude-opus-5-5

Cleanups the stack makes possible but its story doesn't need; kept out of it to keep review focused. Opens once the stack is merged.

Commits
  • Pass facts-only types to Coana with --use-only-socket-facts-artifacts alone: facts generation needs a Coana that takes it, so the Maven-only --maven-use-only-socket-facts older releases took is no longer needed.
  • Rename buildToolScriptOptions to buildListingOptions: the scripts it was named after are gone.
Stack
  1. fix: keep the API token and settings socket-cli passes Coana out of the build tools it runs #1725: Keep the Socket API token out of the tools Coana runs
  2. feat(manifest): generate Socket facts with Coana #1726: Generate Socket facts with Coana
  3. refactor(manifest): delete socket-cli's build-tool scripts and facts assembly #1727: Delete socket-cli's build-tool scripts and facts assembly (internal)
  4. feat(manifest): add socket.json reachability settings for the build tools #1728: socket.json reachability settings for the build tools
  5. feat(manifest): ask for the reachability settings in the setup wizards #1729: Reachability settings in the setup wizards
  6. refactor: follow-ups to generating Socket facts with Coana #1733: Follow-ups (draft) (this PR)

Changelog

No entry: internal.

🤖 Generated with Claude Code

@jfblaa
Jeppe Fredsgaard Blaabjerg (jfblaa) force-pushed the jfblaa/facts-5-wizards branch 2 times, most recently from 244ddca to 283e6d4 Compare November 19, 2026 12:13
Facts generation needs a Coana that takes --use-only-socket-facts-artifacts,
so the Maven-only --maven-use-only-socket-facts that older releases took is
no longer needed.
The build-tool scripts it was named after are gone; it builds the options
listing a build's projects takes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant