2.x: Automatically publish the generated JavaDocs from CI#5996
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5996 +/- ##
===========================================
+ Coverage 98.25% 98.3% +0.04%
- Complexity 6051 6052 +1
===========================================
Files 656 656
Lines 44078 44078
Branches 6118 6118
===========================================
+ Hits 43311 43330 +19
+ Misses 231 220 -11
+ Partials 536 528 -8
Continue to review full report at Codecov.
|
Member
Author
|
PRs don't trigger: https://travis-ci.org/ReactiveX/RxJava/builds/375403314#L4010 Branches do trigger: https://travis-ci.org/ReactiveX/RxJava/builds/375403308#L4018 |
vanniktech
approved these changes
May 6, 2018
| # Code coverage | ||
| after_success: | ||
| - bash <(curl -s https://codecov.io/bash) | ||
| - bash gradle/push.sh |
|
|
||
| # commit all | ||
| echo -e "commit Travis build: $TRAVIS_BUILD_NUMBER for $buildTag" | ||
| git commit --message "Travis build: $TRAVIS_BUILD_NUMBER for $buildTag" |
Collaborator
There was a problem hiding this comment.
Should we include in the message that I'll update the documentation?
Member
Author
There was a problem hiding this comment.
I don't think there is much ambiguity. These go into the gh-pages tab: https://github.com/ReactiveX/RxJava/tree/gh-pages
vanniktech
approved these changes
May 6, 2018
Member
Author
|
Looks like the release mode also works: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a script that publishes the generated JavaDocs from CI back to the
gh-pagesbranch upon successful snapshot and release builds (this latter needs testing though via -RC releases).The snapshot JavaDocs will go into the same directory: http://reactivex.io/RxJava/2.x/javadoc/snapshot/
The release builds update
rxlinks,The
push.shscript uses a Travis-CI secured tokenGITHUB_TOKENto talk to the GitHub API. This token was created for my account via https://github.com/settings/tokens (requires repo direct push access), and provided to Travis via "Environment variables" on the page https://travis-ci.org/ReactiveX/RxJava/settings .If, for some reason the publishing fails, the build still counts as successful. The reason for this is that restarting the otherwise successful build will try to reupload the same library version into maven which fails. In this case, the JavaDocs can be updated via the old manual method.