Skip to content

CsvWriter optionally ommit unneeded comma at the end of every line - #6

Merged
electricessence merged 1 commit into
Open-NET-Libraries:masterfrom
btrappe:master
Mar 25, 2023
Merged

CsvWriter optionally ommit unneeded comma at the end of every line#6
electricessence merged 1 commit into
Open-NET-Libraries:masterfrom
btrappe:master

Conversation

@btrappe

@btrappe btrappe commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

Using CsvWriter added an empty column because to every value field always a comma was appended, also for the last column value. To avoid breaking changes, I added the parameter omitLastComma to CsvWriter.WriteRow function family.

@electricessence

electricessence commented Mar 25, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the PR!
Lemme take a look and see if we can proceed. :)
Just a note, I think this doesn't follow the CSV standard, but I'm happy to accommodate.

@electricessence
electricessence merged commit 009feaf into Open-NET-Libraries:master Mar 25, 2023
@electricessence

Copy link
Copy Markdown
Collaborator

I like where this went. I've got some minor changes I'd like to make.
I'll pull down master and update shortly.

@electricessence

Copy link
Copy Markdown
Collaborator

3.4 released:
https://www.nuget.org/packages/Open.Text.CSV/3.4.0
I refactored and redid a few things, but the API signature you provided is the same except for the parameter names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants