Repository navigation
Conversation
Collaborator
|
Can you describe the real problem that not having this causes? The periods where Loop is not running, data is not accumulating, and when it's running, uploads happen pretty regularly, every 5 min. |
Collaborator
|
Also, this should be against next-dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a remote data service now queries its retained source streams using their existing anchors. The service receives pending data and empty completion callbacks even when no source data changes after launch.
Previously,
addServicestarted these queries butrestoreServiceonly registered the service. A restored service that waits for a complete dose/settings query could therefore wait until a later source event.The regression restores a service against real empty stores and verifies dose, settings and carb callbacks without another source event. This change has no Glooko dependency and does not reset query anchors.
Validation: the focused
LoopTests/RemoteDataServicesManagerTeststest passed on the iOS 26.3 simulator with Xcode 27. The standalone upstream workspace was built without GlookoService. Coverage was disabled for the completed run after an initial run passed the test but stalled during Xcode's post-test cleanup.