Skip to content

firestore: listen_multiple test is flakey #2529

Closed

Description

@BenWhitehead

In which file did you encounter the issue?

https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/firestore/cloud-client/snippets.py#L679

Did you change the file? If so, how?

no changes

Describe the issue

The listen_multiple firestore sample is flakey, likely due to not waiting appropriately for all of the async events to happen before the assertions.
To fix this flakeyness, someone with good python multithreading knowledge will be needed to add the correct await conditions.

Activity

  1. added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Nov 14, 2019
  2. added
    🚨This issue needs some love.
    and removed
    🚨This issue needs some love.
    on Nov 21, 2019
  3. andrewferlitsch commented on Dec 3, 2019

    @andrewferlitsch
    Contributor

    @BenWhitehead If the test is failing (flaky) in Fusion, shouldn't a bug be opened in buganizer and not here in issues?

  4. BenWhitehead commented on Dec 3, 2019

    @BenWhitehead
    ContributorAuthor

    @andrewferlitsch The flakiness of this test is due to the current implementation of some async threads and timeouts waiting for various events to happen over the course of the test run. These failures are independent of Fusion and can happen in any environment. A similar issue was present in the java tests that I fixed here, however I do not possess the requisite python threading knowledge to be able to fix this on my own and will need help from someone that does.

  5. andrewferlitsch commented on Dec 3, 2019

    @andrewferlitsch
    Contributor

    @GoogleCloudPlatform/python-samples-owners Is there someone whom can help Ben with how to do this fix in Python?

  6. added
    🚨This issue needs some love.
    and removed
    🚨This issue needs some love.
    on Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: firestoreIssues related to the Firestore API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions