asyncpg pool support improved #1180

Activity

1. d1manson

   added

   type: docsImprovement to the documentation for an API.Improvement to the documentation for an API.

   on Oct 22, 2024
2. blunderbuss-gcf

   assigned

   jackwotherspoon

   on Oct 22, 2024
3. jackwotherspoon

   added

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   on Oct 22, 2024
4. jackwotherspoon commented on Oct 22, 2024

   

   jackwotherspoon

   on Oct 22, 2024

   Collaborator

   More actions

   Hi @d1manson, thanks for pointing this out! (and being the one to commit this awesome feature) 😄

   Do you have a working code sample handy? If so I'll test it out and get it added to our docs ASAP ✅

   I assume it probably works similar to SQLAlchemy and I can just pass the getconn as the connect arg to async.create_pool?

   Thanks again for this awesome feature and putting it on our radar 👍
5. d1manson commented on Oct 22, 2024

   

   d1manson

   on Oct 22, 2024

   Author

   More actions

   @jackwotherspoon - yes exactly. the getconn will need to have a call signature of async def getconn(dsn, **kwargs) I think, but it's up to the user to decide if they actually use those args or have some other mechanism for passing in the config to the connection.
6. jackwotherspoon commented on Oct 24, 2024

   

   jackwotherspoon

   on Oct 24, 2024

   Collaborator

   More actions

   yes exactly. the getconn will need to have a call signature of async def getconn(dsn, **kwargs) I think, but it's up to the user to decide if they actually use those args or have some other mechanism for passing in the config to the connection.

   @d1manson do you have a working sample handy? I did a quick test and am running into some issues...
7. jackwotherspoon commented on Oct 24, 2024

   

   jackwotherspoon

   on Oct 24, 2024

   Collaborator

   More actions

   Got a working example actually 👏

   import asyncpg
   from google.cloud.sql.connector import Connector
   
   async def main():
       loop = asyncio.get_running_loop()
       async with Connector(loop=loop) as connector:
   
           async def getconn(instance_connection_name, **kwargs) -> asyncpg.Connection:
               return await connector.connect_async(
                   instance_connection_name,
                   "asyncpg",
                   user="my-user",
                   password="my-password",
                   db="my-db",
                   **kwargs,
               )
   
           pool = await asyncpg.create_pool(
               "my-project:my-region:my-instance", connect=getconn
           )
           async with pool.acquire() as conn:
               hello = await conn.fetch("SELECT 'Hello World!'")

   Will get a PR up shortly with a clean example.

   👍React with 👍1Reacted by Daniel Manson
8. jackwotherspoon

   closed this as completedin #1182on Oct 25, 2024