This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 16, 2021. It is now read-only.
reenable traceid logic in the logs #184
Description
It seems that https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/93/files
did not take care of the logic for logging traceid. It got removed.
There is a test showing how to do it in https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/blob/master/appengine-java-logging/src/test/java/com/google/apphosting/logging/JsonFormatterTest.java
search for "traceId"
There is no real doc for that (shame-) but we need to have the correct LogContext with the traceid when possible.
Metadata
Metadata
Assignees
Labels
No labels
Activity
ludoch commentedon Feb 25, 2016
Also, I did not follow this area, but I am confused with VmRuntimeLogHandler versus VmRuntimeFileLogHandler
ludoch commentedon Feb 25, 2016
My understanding is that we would not need anymore VmRuntimeLogHandler but it would be nice if we can keep the compat way of defining java.util.logging.config.file for log levels?
ludoch commentedon Feb 25, 2016
As a side effect VmAppLogsWriter would disappear.
ludoch commentedon Feb 25, 2016
I think java.util.logging.config.file is already covered by standard, so this might not be an issue at all.
Just some cleanup and adding the traceid is needed.
ludoch commentedon Feb 29, 2016
Hi @gregw: let me know if you have time to look at this one, or I will look at it.
gregw commentedon Feb 29, 2016
I've not yet looked at this. If you don't get it done then I can look at it Wednesday or Thursday.
Issue GoogleCloudPlatform#184 Log TraceID
Merge pull request #196 from jetty-project/issue-184