Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Annotated Servlets do not work with quickstart disabled. #123

Open

Description

@gregw

A webapp with annotated servlets does not deploy correctly if quickstart is disabled. The annotations appear to not be scanned

Activity

  1. ludoch commented on Nov 15, 2015

    @ludoch
    Contributor

    related to #122

    the current maven plugin delegates all the process to the gcloud tool which bundles the current Jetty 9.2 used for the current Java7 Jetty compat runtime.
    We need to keep this and this will not evolve a lot until we remove it entirely.
    Meanwhile we need to find the SDK story for the new Jetty9.3/Java8 runtime.
    For internal reasons, we cannot have 2 Jetty binaries inside Google.
    What we can do for that is first make it work with Maven and add the logic in the Maven plugin that could easily be modified to:
    1/ depend on Maven Jetty9.3.x artifacts (especially quickstart)
    2/ depend on a modified jetty compat library defined in this git project to export the defaultweb.xml as a resource of the compat library
    3/ modify the maven plugin to call the quickstart logic with the correct webdefault.xml defined here (async-branch) only when we can detect that the user intents to use the new compat runtime, not the one bundled in the cloud SDK.
    I've done a proto for that, and it seems doable.

    For the appengine-java-vm-runtime artifact:
    diff.txt

  2. ludoch commented on Nov 15, 2015

    @ludoch
    Contributor

    And for the gcloud maven plugin (https://github.com/GoogleCloudPlatform/gcloud-maven-plugin) , that would be:
    d2.txt

  3. modified the milestones: async-support, Beta on May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions