Skip to content

[react-plotly.js] added missing onBeforeHover event to interface - #54304

Merged
typescript-bot merged 6 commits into
DefinitelyTyped:masterfrom
phuebner:react-plotly.js_onBeforeHover
Jul 9, 2021
Merged

typescript-bot merged 6 commits into
DefinitelyTyped:masterfrom
phuebner:react-plotly.js_onBeforeHover

Conversation

@phuebner

@phuebner phuebner commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot

typescript-bot commented Jul 6, 2021 •

Copy link
Copy Markdown
Contributor

@phuebner Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 54304,
  "author": "phuebner",
  "headCommitOid": "abc46249c65b2f7c65a1ebd51f39d4c2440784ca",
  "lastPushDate": "2021-07-08T08:58:44.000Z",
  "lastActivityDate": "2021-07-09T05:31:47.000Z",
  "mergeOfferDate": "2021-07-09T01:18:51.000Z",
  "mergeRequestDate": "2021-07-09T05:31:47.000Z",
  "mergeRequestUser": "phuebner",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-plotly.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-plotly.js/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-plotly.js/react-plotly.js-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "jonfreedman",
        "gricey432"
      ],
      "addedOwners": [
        "phuebner"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gricey432",
      "date": "2021-07-09T01:18:16.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 874626290,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Edits Owners This PR adds or removes owners label Jul 6, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

🔔 @jonfreedman @gricey432 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Check Config Changes a module config files The CI failed When GH Actions fails labels Jul 6, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

@phuebner The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed Check Config Changes a module config files The CI failed When GH Actions fails labels Jul 6, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

@phuebner The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed The CI failed When GH Actions fails labels Jul 6, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

@phuebner Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

Comment thread types/react-plotly.js/index.d.ts Resolved
@typescript-bot

Copy link
Copy Markdown
Contributor

@phuebner One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Jul 8, 2021
@typescript-bot typescript-bot removed Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Revision needed This PR needs code changes before it can be merged. labels Jul 8, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

@gricey432 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Jul 9, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

@phuebner: Everything looks good here. I am ready to merge this PR (at abc4624) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jonfreedman, @gricey432: you can do this too.)

@phuebner

phuebner commented Jul 9, 2021

Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot
typescript-bot merged commit 3984e1b into DefinitelyTyped:master Jul 9, 2021
@typescript-bot

Copy link
Copy Markdown
Contributor

I just published @types/react-plotly.js@2.5.0 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Owners This PR adds or removes owners Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants