Repository navigation
[react-plotly.js] added missing onBeforeHover event to interface - #54304
typescript-bot merged 6 commits into
Conversation
|
@phuebner Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54304,
"author": "phuebner",
"headCommitOid": "abc46249c65b2f7c65a1ebd51f39d4c2440784ca",
"lastPushDate": "2021-07-08T08:58:44.000Z",
"lastActivityDate": "2021-07-09T05:31:47.000Z",
"mergeOfferDate": "2021-07-09T01:18:51.000Z",
"mergeRequestDate": "2021-07-09T05:31:47.000Z",
"mergeRequestUser": "phuebner",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-plotly.js",
"kind": "edit",
"files": [
{
"path": "types/react-plotly.js/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-plotly.js/react-plotly.js-tests.tsx",
"kind": "test"
}
],
"owners": [
"jonfreedman",
"gricey432"
],
"addedOwners": [
"phuebner"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gricey432",
"date": "2021-07-09T01:18:16.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 874626290,
"ciResult": "pass"
} |
|
🔔 @jonfreedman @gricey432 — please review this PR in the next few days. Be sure to explicitly select |
|
@phuebner The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
This reverts commit 7a5fc98.
|
@phuebner The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@phuebner Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
|
@phuebner One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@gricey432 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@phuebner: Everything looks good here. I am ready to merge this PR (at abc4624) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@jonfreedman, @gricey432: you can do this too.) |
|
Ready to merge |
|
I just published |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
Provide a URL to documentation or source code which provides context for the suggested changes:
add plotly_beforehover event plotly/react-plotly.js#216
https://github.com/plotly/plotly.js/blob/master/src/components/fx/hover.js
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.