Skip to content

58 analyzer stabilization const correctness cross tu robustness and appcli refactor#59

Merged
SizzleUnrlsd merged 33 commits into
mainfrom
58-analyzer-stabilization-const-correctness-cross-tu-robustness-and-appcli-refactor
Mar 19, 2026
Merged

58 analyzer stabilization const correctness cross tu robustness and appcli refactor#59
SizzleUnrlsd merged 33 commits into
mainfrom
58-analyzer-stabilization-const-correctness-cross-tu-robustness-and-appcli-refactor

Conversation

@SizzleUnrlsd
Copy link
Copy Markdown
Contributor

@SizzleUnrlsd SizzleUnrlsd commented Mar 14, 2026

No description provided.

@SizzleUnrlsd
chore(config): set warnings-only default to false
026d6c0
@SizzleUnrlsd
build(cmake): add ParameterDebugBinding source to analyzer target
9624d53
@SizzleUnrlsd
refactor(analysis): replace raw const-param debug fields with Paramet…
1813f8a 
…erDebugBinding
@SizzleUnrlsd
refactor(app): simplify runAnalyzerApp signature by removing external…
5b1926e 
… LLVMContext
@SizzleUnrlsd
refactor(main): delegate LLVMContext lifecycle to analyzer app
b31f398
@SizzleUnrlsd
feat(analysis): improve const-parameter detection with tri-state writ…
19a9fff 
…e inference and confidence scoring
@SizzleUnrlsd
refactor(analysis): make mem intrinsic callee resolution const-correct
1c6c63d
@SizzleUnrlsd
refactor(analysis): use const TargetLibraryInfo in known sink lookup
8d537e4
@SizzleUnrlsd
refactor(analysis): make alloca fallback checks const-safe
53a1b8e
@SizzleUnrlsd
refactor(analysis): apply const-correctness to stack escape fact coll…
42d70e0 
…ection
@SizzleUnrlsd
refactor(pipeline): mark function attrs pass state as const
aa0d77f
@SizzleUnrlsd
feat(diagnostics): emit const-parameter findings from debug binding w…
5aed5ff 
…ith confidence
@SizzleUnrlsd
fix(app): isolate cross-tu resource summary cache keys by analysis fi…
9cb60ba 
…lters
@SizzleUnrlsd
refactor(cli): unify SMT option handlers with optional error results
297cd68
@SizzleUnrlsd
feat(analysis): add ParameterDebugBinding interface for LLVM debug me…
0bd5373 
…tadata
@SizzleUnrlsd
feat(analysis): implement scored parameter debug binding resolution
a777e53
@SizzleUnrlsd
docs(issues): document self-analysis stabilization scope and follow-up
a61fbbc
@SizzleUnrlsd SizzleUnrlsd self-assigned this Mar 14, 2026
@SizzleUnrlsd SizzleUnrlsd linked an issue Mar 14, 2026 that may be closed by this pull request
# Analyzer Stabilization: const-correctness, cross-TU robustness, and app/CLI refactor #58
Closed
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 14, 2026
View reviewed changes
Comment thread src/analysis/ParameterDebugBinding.cpp Fixed
Comment thread src/app/AnalyzerApp.cpp
public:
AppStatus execute(RunPlan& plan, llvm::LLVMContext& context,
std::vector<AnalysisEntry>& results) const override
AppStatus execute(RunPlan& plan, std::vector<AnalysisEntry>& results) const override

Check notice

Code scanning / coretrace-stack-analyzer

[ !Info! ] ConstParameterNotModified.Reference: parameter 'plan' in function 'DirectModuleLoadingExecutionStrategy::execute(RunPlan&, std::vector<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, ctrace::stack::AnalysisResult>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, ctrace::stack::AnalysisResult> > >&) const' is never used to modify the referred object ↳ current type: RunPlan &plan ↳ suggested type: const RunPlan &plan Note

[ !Info! ] ConstParameterNotModified.Reference: parameter 'plan' in function 'DirectModuleLoadingExecutionStrategy::execute(RunPlan&, std::vector<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, ctrace::stack::AnalysisResult>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, ctrace::stack::AnalysisResult> > >&) const' is never used to modify the referred object ↳ current type: RunPlan &plan ↳ suggested type: const RunPlan &plan
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 19, 2026
View reviewed changes
Comment thread src/analysis/InputPipeline.cpp
}

LanguageType detectLanguageFromFile(const std::string& path, llvm::LLVMContext& ctx)
LanguageType detectLanguageFromFile(const std::string& path, llvm::LLVMContext&)

Check notice

Code scanning / coretrace-stack-analyzer

[ !Info! ] ConstParameterNotModified.Reference: parameter 'param2' in function 'ctrace::stack::analysis::detectLanguageFromFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, llvm::LLVMContext&)' is never used to modify the referred object ↳ current type: LLVMContext &param2 ↳ suggested type: const LLVMContext &param2 Note

[ !Info! ] ConstParameterNotModified.Reference: parameter 'param2' in function 'ctrace::stack::analysis::detectLanguageFromFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, llvm::LLVMContext&)' is never used to modify the referred object ↳ current type: LLVMContext &param2 ↳ suggested type: const LLVMContext &param2
Comment thread src/analyzer/AnalysisPipeline.cpp
#include <chrono>
#include <cctype>
#include <cstdint>
#include <cstdlib>

Check notice

Code scanning / coretrace-stack-analyzer

[ !Info! ] ConstParameterNotModified.Reference: parameter 'subscriber' in function 'ctrace::stack::analyzer::InstructionSubscriberRegistry::add(ctrace::stack::analyzer::InstructionSubscriber&)' is never used to modify the referred object ↳ current type: InstructionSubscriber &subscriber ↳ suggested type: const InstructionSubscriber &subscriber Note

[ !Info! ] ConstParameterNotModified.Reference: parameter 'subscriber' in function 'ctrace::stack::analyzer::InstructionSubscriberRegistry::add(ctrace::stack::analyzer::InstructionSubscriber&)' is never used to modify the referred object ↳ current type: InstructionSubscriber &subscriber ↳ suggested type: const InstructionSubscriber &subscriber
Comment thread src/analyzer/AnalysisPipeline.cpp
std::uint8_t reservedPadding[6] = {};
};

static PipelineStep* findStep(std::vector<PipelineStep>& steps, std::string_view label)

Check notice

Code scanning / coretrace-stack-analyzer

[ !Info! ] ConstParameterNotModified.Reference: parameter 'label.coerce0' in function 'ctrace::stack::analyzer::(anonymous namespace)::findStep(std::vector<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep, std::allocator<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep> >&, std::basic_string_view<char, std::char_traits<char> >)' is never used to modify the referred object ↳ current type: vector<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep, std::allocator<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep> > &label.coerce0 ↳ suggested type: const vector<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep, std::allocator<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep> > &label.coerce0 Note

[ !Info! ] ConstParameterNotModified.Reference: parameter 'label.coerce0' in function 'ctrace::stack::analyzer::(anonymous namespace)::findStep(std::vector<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep, std::allocator<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep> >&, std::basic_string_view<char, std::char_traits<char> >)' is never used to modify the referred object ↳ current type: vector<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep, std::allocator<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep> > &label.coerce0 ↳ suggested type: const vector<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep, std::allocator<ctrace::stack::analyzer::(anonymous namespace)::PipelineStep> > &label.coerce0
Comment thread src/app/AnalyzerApp.cpp

void strongConnect(std::size_t v, const std::vector<std::unordered_set<std::size_t>>& edges)
{
index[v] = lowlink[v] = nextIndex++;

Check notice

Code scanning / coretrace-stack-analyzer

None Note

[ !Info! ] recursive or mutually recursive function detected
@SizzleUnrlsd SizzleUnrlsd merged commit 40ebaf2 into main Mar 19, 2026
11 checks passed
@SizzleUnrlsd SizzleUnrlsd deleted the 58-analyzer-stabilization-const-correctness-cross-tu-robustness-and-appcli-refactor branch March 19, 2026 08:18
@SizzleUnrlsd SizzleUnrlsd linked an issue Mar 23, 2026 that may be closed by this pull request
Reduce ConstParameterNotModified false positives by fixing IR-to-source parameter binding and tightening mutation analysis #57
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SizzleUnrlsd SizzleUnrlsd

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@SizzleUnrlsd @github-advanced-security