Fix problem with Mockery expectations hiding fails#6
Merged
enumag merged 1 commit intoCodeception:masterfrom Sep 12, 2015
Merged
Fix problem with Mockery expectations hiding fails#6enumag merged 1 commit intoCodeception:masterfrom
enumag merged 1 commit intoCodeception:masterfrom
Conversation
_after() is always run, even if a regular assertion fails the test. This causes mockery to hijack the error, if it had any expectations in the test. This fix prevents Mockery from running its expectations, if the test has already failed. So that the correct failure message is displayed.
enumag
added a commit
that referenced
this pull request
Sep 12, 2015
Ignore exception from Mockery if the test already failed
Member
|
@akimsko Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_after() is always run, even if a regular assertion fails the test. This causes mockery to hijack the error, if it had any expectations in the test.
This fix prevents Mockery from running its expectations, if the test has already failed. So that the correct failure message is displayed.