Skip to content
This repository was archived by the owner on Nov 14, 2017. It is now read-only.

Make use of subspecs to trigger only necessary dependencies. #47

Merged
CodaFi merged 2 commits into from
Jul 6, 2015
Merged

Make use of subspecs to trigger only necessary dependencies. #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3321624
Make use of subspecs to trigger only necessary dependecies
yarry Jul 5, 2015
67a2a3a
Rename 'Progress' subspec and make it turn it off by default
yarry Jul 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions AFNetworking-RACExtensions.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,23 @@ Pod::Spec.new do |s|
s.source = { :git => "https://github.com/CodaFi/AFNetworking-RACExtensions.git", :tag => "#{s.version}" }
s.ios.deployment_target = '6.0'
s.osx.deployment_target = '10.8'
s.source_files = 'RACAFNetworking'
s.requires_arc = true
s.dependency 'AFNetworking', '~> 2.0'
s.dependency 'ReactiveCocoa', '~> 2.0'
s.default_subspecs = 'NSURLConnection', 'NSURLSession'

s.subspec 'ExperimentalProgressCallbacks' do |ss|
ss.dependency 'ReactiveCocoa/Core', '~> 2.0'
ss.source_files = 'RACAFNetworking/RACSubscriber+AFProgressCallbacks.{h,m}'
end

@CodaFi CodaFi Jul 5, 2015

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not recommend making that part of this library public.

@yarry yarry Jul 6, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I just remove this subspec?
Or make it unavailable by default?


s.subspec 'NSURLConnection' do |ss|
ss.dependency 'AFNetworking/NSURLConnection', '~> 2.0'
ss.dependency 'ReactiveCocoa/Core', '~> 2.0'
ss.source_files = 'RACAFNetworking/AFURLConnectionOperation+RACSupport.{h,m}', 'RACAFNetworking/AFHTTPRequestOperationManager+RACSupport.{h,m}'
end

s.subspec 'NSURLSession' do |ss|
ss.dependency 'AFNetworking/NSURLSession', '~> 2.0'
ss.dependency 'ReactiveCocoa/Core', '~> 2.0'
ss.source_files = 'RACAFNetworking/AFHTTPSessionManager+RACSupport.{h,m}'
end
end