Fix: Incorrect type declaration about 'Number'#2278
Merged
dcodeIO merged 2 commits intoAssemblyScript:mainfrom May 3, 2022
Merged
Fix: Incorrect type declaration about 'Number'#2278dcodeIO merged 2 commits intoAssemblyScript:mainfrom
dcodeIO merged 2 commits intoAssemblyScript:mainfrom
Conversation
Member
|
Wondering if it is sufficient to change declare type Number = typeof F64;to declare type Number = F64;to make it the desired alias, including all properties? |
Contributor
Author
I think it's better and add a new commit. *but it should be: declare type Number = _Float; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2260 ,
Numberwas declared astypeof F64(equivalent totypeof _Float), which causes all numbers to be considered as aClasswith some methods that don't belong to it, just like:I updated the declaration of
Numberaccording to the document. I think this is a small change, so I submit PR directly.⯈
⯈
⯈