Skip to content

Revert "fix: Duplicate LLM calls (#981)" - #997

Merged
dot-agi merged 1 commit into
mainfrom
fix/crewai-duplicate-llms
May 21, 2025
Merged

dot-agi merged 1 commit into
mainfrom
fix/crewai-duplicate-llms

Conversation

@dot-agi

@dot-agi dot-agi commented May 21, 2025

Copy link
Copy Markdown
Member

This reverts commit 63fdd7f.

Because #987 fixes the original issue.

@codecov

codecov Bot commented May 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/instrumentation/crewai/instrumentation.py 0.00% 36 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dot-agi
dot-agi enabled auto-merge (squash) May 21, 2025 19:18
@dot-agi
dot-agi requested review from Dwij1704 and Copilot May 21, 2025 19:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the changes introduced in commit 63fdd7f because commit #987 already fixes the original duplicate LLM call issue.

  • Reverts provider-specific instrumentation logic for LLM calls.
  • Simplifies exception handling and logging within the span context.
  • Restores previous behavior regarding trace creation.
Comments suppressed due to low confidence (2)

agentops/instrumentation/crewai/instrumentation.py:412

  • With the reversion removing the provider instrumentation logic, please verify that the simplified approach maintains correct behavior across all LLM providers.
llm = instance.model if hasattr(instance, "model") else "llm"

agentops/instrumentation/crewai/instrumentation.py:461

  • [nitpick] The change to 'ex' improves clarity; ensure that similar exception handling in other parts of the codebase follows a consistent naming pattern.
except Exception as ex:

@dot-agi
dot-agi merged commit 85a2041 into main May 21, 2025
@dot-agi
dot-agi deleted the fix/crewai-duplicate-llms branch May 21, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants