feat(Dropdown): Add support for dropleft and dropright (#785)#813
Merged
Conversation
TheSharpieOne
left a comment
Member
There was a problem hiding this comment.
Just some small nits to help reduce the amount of code.
| const propTypes = { | ||
| disabled: PropTypes.bool, | ||
| dropup: PropTypes.bool, | ||
| dropup: deprecated(PropTypes.bool, 'Please use the prop "direction"'), |
Member
There was a problem hiding this comment.
I would also indicate the using the value "up": 'Please use the prop "direction" with the value "up".'
| dropdown: !group && !addonType, | ||
| show: isOpen, | ||
| dropup: dropup, | ||
| dropup: direction === 'up', |
Member
There was a problem hiding this comment.
These three lines can be
direction !== 'down' && `drop${direction}`
| const position1 = context.dropup ? 'top' : 'bottom'; | ||
|
|
||
| let position1; | ||
| switch (context.direction) { |
Member
There was a problem hiding this comment.
You can use a hashmap instead and it will be more performant and less code.
// this defined outside of the component:
const directionPositionMap = {
up: 'top',
left: 'left',
right: 'right',
down: 'bottom',
};
// this right here:
const position1 = directionPositionMap[context.direction] || 'bottom';
You don't really need the || 'bottom' as the contextTypes should ensure it is in the hashmap.... but just in case?
TheSharpieOne
approved these changes
Feb 7, 2018
jlaramie
pushed a commit
to jlaramie/reactstrap
that referenced
this pull request
Mar 9, 2018
This was referenced Mar 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for dropleft and dropright (#785)