From c9c3000e42c21b3084a274861aa1c6d557bffa9f Mon Sep 17 00:00:00 2001 From: Maksim Kotlyar Date: Sat, 10 Mar 2018 17:42:50 +0200 Subject: [PATCH 01/11] [fs] Throw if "|{" found in message body. --- pkg/fs/FsProducer.php | 7 ++++++- pkg/fs/Tests/Functional/FsProducerTest.php | 16 ++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/pkg/fs/FsProducer.php b/pkg/fs/FsProducer.php index a8dbac925..57c90cbcc 100644 --- a/pkg/fs/FsProducer.php +++ b/pkg/fs/FsProducer.php @@ -52,7 +52,12 @@ public function send(PsrDestination $destination, PsrMessage $message) $message->setHeader('x-expire-at', microtime(true) + ($this->timeToLive / 1000)); } - $rawMessage = '|'.json_encode($message); + $rawMessage = json_encode($message); + if (false !== strpos($rawMessage, '|{')) { + throw new \LogicException('The delimiter sequence "|{" found in message body.'); + } + + $rawMessage = '|'.$rawMessage; if (JSON_ERROR_NONE !== json_last_error()) { throw new \InvalidArgumentException(sprintf( diff --git a/pkg/fs/Tests/Functional/FsProducerTest.php b/pkg/fs/Tests/Functional/FsProducerTest.php index 634e09882..ead7eaa7b 100644 --- a/pkg/fs/Tests/Functional/FsProducerTest.php +++ b/pkg/fs/Tests/Functional/FsProducerTest.php @@ -45,4 +45,20 @@ public function testShouldStoreFilesToFileInExpectedFormat() file_get_contents(sys_get_temp_dir().'/fs_test_queue') ); } + + /** + * @group bug + * @group bug390 + */ + public function testThrowIfDelimiterSymbolsFoundInMessageBody() + { + $queue = $this->fsContext->createQueue('fs_test_queue'); + + $message = $this->fsContext->createMessage(' |{"body":"aMessageData","properties":{"enqueue.topic_name":"user_updated"},"headers":{"content_type":"text\/plain","message_id":"90979b6c-d9ff-4b39-9938-878b83a95360","timestamp":1519899428,"reply_to":null,"co +rrelation_id":""}}'); + + $this->expectException(\LogicException::class); + $this->expectExceptionMessage('The delimiter sequence "|{" found in message body.'); + $this->fsContext->createProducer()->send($queue, $message); + } } From 23ef19d09e4e0e946077d52992cfe1bdc493ed69 Mon Sep 17 00:00:00 2001 From: Maksim Kotlyar Date: Sat, 10 Mar 2018 18:01:24 +0200 Subject: [PATCH 02/11] [fs] Escape delimiter symbols. --- pkg/fs/FsConsumer.php | 3 ++- pkg/fs/FsProducer.php | 5 +--- pkg/fs/Tests/Functional/FsConsumerTest.php | 27 ++++++++++++++++++++++ pkg/fs/Tests/Functional/FsProducerTest.php | 16 ------------- 4 files changed, 30 insertions(+), 21 deletions(-) diff --git a/pkg/fs/FsConsumer.php b/pkg/fs/FsConsumer.php index c42ea4dfc..f0d8463fe 100644 --- a/pkg/fs/FsConsumer.php +++ b/pkg/fs/FsConsumer.php @@ -131,7 +131,8 @@ public function receiveNoWait() ftruncate($file, fstat($file)['size'] - strlen($frame)); rewind($file); - $rawMessage = substr(trim($frame), 1); + $rawMessage = str_replace('\|\{', '|{', $frame); + $rawMessage = substr(trim($rawMessage), 1); if ($rawMessage) { try { diff --git a/pkg/fs/FsProducer.php b/pkg/fs/FsProducer.php index 57c90cbcc..21f890575 100644 --- a/pkg/fs/FsProducer.php +++ b/pkg/fs/FsProducer.php @@ -53,10 +53,7 @@ public function send(PsrDestination $destination, PsrMessage $message) } $rawMessage = json_encode($message); - if (false !== strpos($rawMessage, '|{')) { - throw new \LogicException('The delimiter sequence "|{" found in message body.'); - } - + $rawMessage = str_replace('|{', '\|\{', $rawMessage); $rawMessage = '|'.$rawMessage; if (JSON_ERROR_NONE !== json_last_error()) { diff --git a/pkg/fs/Tests/Functional/FsConsumerTest.php b/pkg/fs/Tests/Functional/FsConsumerTest.php index f3a641159..d04090d18 100644 --- a/pkg/fs/Tests/Functional/FsConsumerTest.php +++ b/pkg/fs/Tests/Functional/FsConsumerTest.php @@ -171,4 +171,31 @@ public function testShouldThrowExceptionWhenFrameSizeNotDivideExactly() $this->expectExceptionMessage('The frame size is "12" and it must divide exactly to 64 but it leaves a reminder "12".'); $consumer->receiveNoWait(); } + + /** + * @group bug + * @group bug390 + */ + public function testShouldUnEscapeDelimiterSymbolsInMessageBody() + { + $context = $this->fsContext; + $queue = $context->createQueue('fs_test_queue'); + $context->purge($queue); + + $message = $this->fsContext->createMessage(' |{"body":"aMessageData","properties":{"enqueue.topic_name":"user_updated"},"headers":{"content_type":"text\/plain","message_id":"90979b6c-d9ff-4b39-9938-878b83a95360","timestamp":1519899428,"reply_to":null,"correlation_id":""}}'); + + $this->fsContext->createProducer()->send($queue, $message); + + $this->assertSame(0, strlen(file_get_contents(sys_get_temp_dir().'/fs_test_queue')) % 64); + $this->assertSame( + ' |{"body":" \|\{\"body\":\"aMessageData\",\"properties\":{\"enqueue.topic_name\":\"user_updated\"},\"headers\":{\"content_type\":\"text\\\\\/plain\",\"message_id\":\"90979b6c-d9ff-4b39-9938-878b83a95360\",\"timestamp\":1519899428,\"reply_to\":null,\"correlation_id\":\"\"}}","properties":[],"headers":[]}', + file_get_contents(sys_get_temp_dir().'/fs_test_queue') + ); + + $consumer = $context->createConsumer($queue); + + $message = $consumer->receiveNoWait(); + + $this->assertSame(' |{"body":"aMessageData","properties":{"enqueue.topic_name":"user_updated"},"headers":{"content_type":"text\/plain","message_id":"90979b6c-d9ff-4b39-9938-878b83a95360","timestamp":1519899428,"reply_to":null,"correlation_id":""}}', $message->getBody()); + } } diff --git a/pkg/fs/Tests/Functional/FsProducerTest.php b/pkg/fs/Tests/Functional/FsProducerTest.php index ead7eaa7b..634e09882 100644 --- a/pkg/fs/Tests/Functional/FsProducerTest.php +++ b/pkg/fs/Tests/Functional/FsProducerTest.php @@ -45,20 +45,4 @@ public function testShouldStoreFilesToFileInExpectedFormat() file_get_contents(sys_get_temp_dir().'/fs_test_queue') ); } - - /** - * @group bug - * @group bug390 - */ - public function testThrowIfDelimiterSymbolsFoundInMessageBody() - { - $queue = $this->fsContext->createQueue('fs_test_queue'); - - $message = $this->fsContext->createMessage(' |{"body":"aMessageData","properties":{"enqueue.topic_name":"user_updated"},"headers":{"content_type":"text\/plain","message_id":"90979b6c-d9ff-4b39-9938-878b83a95360","timestamp":1519899428,"reply_to":null,"co -rrelation_id":""}}'); - - $this->expectException(\LogicException::class); - $this->expectExceptionMessage('The delimiter sequence "|{" found in message body.'); - $this->fsContext->createProducer()->send($queue, $message); - } } From 9c7aa7f64ea48447f7874904579cb9f972886c37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrius=20=C5=A0ilgalis?= Date: Mon, 12 Mar 2018 11:38:58 +0200 Subject: [PATCH 03/11] Update sqs transport factory with missing endpoint parameter --- pkg/sqs/Symfony/SqsTransportFactory.php | 1 + pkg/sqs/Tests/Symfony/SqsTransportFactoryTest.php | 2 ++ 2 files changed, 3 insertions(+) diff --git a/pkg/sqs/Symfony/SqsTransportFactory.php b/pkg/sqs/Symfony/SqsTransportFactory.php index e5f843a48..58c0c1a12 100644 --- a/pkg/sqs/Symfony/SqsTransportFactory.php +++ b/pkg/sqs/Symfony/SqsTransportFactory.php @@ -44,6 +44,7 @@ public function addConfiguration(ArrayNodeDefinition $builder) ->defaultTrue() ->info('the connection will be performed as later as possible, if the option set to true') ->end() + ->scalarNode('endpoint')->defaultNull()->end() ; } diff --git a/pkg/sqs/Tests/Symfony/SqsTransportFactoryTest.php b/pkg/sqs/Tests/Symfony/SqsTransportFactoryTest.php index 350c4dc96..a263856a3 100644 --- a/pkg/sqs/Tests/Symfony/SqsTransportFactoryTest.php +++ b/pkg/sqs/Tests/Symfony/SqsTransportFactoryTest.php @@ -52,6 +52,7 @@ public function testShouldAllowAddConfiguration() 'retries' => 5, 'version' => 'theVersion', 'lazy' => false, + 'endpoint' => 'theEndpoint', ]]); $this->assertEquals([ @@ -62,6 +63,7 @@ public function testShouldAllowAddConfiguration() 'retries' => 5, 'version' => 'theVersion', 'lazy' => false, + 'endpoint' => 'theEndpoint', ], $config); } From b17432759db6c3cac92533c234772112357dd383 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrius=20=C5=A0ilgalis?= Date: Mon, 12 Mar 2018 11:39:19 +0200 Subject: [PATCH 04/11] Update test to not create database if already exists --- bin/test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/test b/bin/test index 10d072386..7a91fb8c3 100755 --- a/bin/test +++ b/bin/test @@ -37,7 +37,7 @@ waitForService beanstalkd 11300 50 waitForService gearmand 4730 50 waitForService kafka 9092 50 -php pkg/job-queue/Tests/Functional/app/console doctrine:database:create +php pkg/job-queue/Tests/Functional/app/console doctrine:database:create --if-not-exists php pkg/job-queue/Tests/Functional/app/console doctrine:schema:update --force #php pkg/enqueue-bundle/Tests/Functional/app/console.php config:dump-reference enqueue From 73410e3ca9bb4c2cb8f5d2c2c8b5a04897709718 Mon Sep 17 00:00:00 2001 From: Pascal Borreli Date: Fri, 23 Mar 2018 10:41:01 +0100 Subject: [PATCH 05/11] Fixed typo --- docs/bundle/async_events.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/bundle/async_events.md b/docs/bundle/async_events.md index 68ebdfff8..b2e7ea5ee 100644 --- a/docs/bundle/async_events.md +++ b/docs/bundle/async_events.md @@ -154,7 +154,7 @@ and register it: # app/config/config.yml services: - acme.foo_event_transofrmer: + acme.foo_event_transformer: class: 'AcmeBundle\Listener\FooEventTransformer' arguments: ['@doctrine'] tags: From 3561c36b4463ab671c0722ff50347e02eed6789e Mon Sep 17 00:00:00 2001 From: Pascal Borreli Date: Fri, 23 Mar 2018 11:52:55 +0100 Subject: [PATCH 06/11] Fixed typos --- docker-compose.yml | 2 +- docs/bundle/{debuging.md => debugging.md} | 0 docs/bundle/functional_testing.md | 2 +- docs/bundle/job_queue.md | 2 +- docs/client/message_examples.md | 2 +- docs/client/supported_brokers.md | 2 +- docs/consumption/message_processor.md | 2 +- docs/contribution.md | 2 +- docs/index.md | 2 +- docs/laravel/queues.md | 2 +- docs/quick_tour.md | 6 +++--- docs/transport/amqp.md | 2 +- docs/transport/amqp_bunny.md | 2 +- docs/transport/amqp_lib.md | 2 +- docs/transport/kafka.md | 2 +- ...hp => AmqpSendAndReceiveTimestampAsIntegerTest.php} | 2 +- .../Tests/Functional/AmqpCommonUseCasesTest.php | 4 ++-- .../Tests/Functional/AmqpConsumptionUseCasesTest.php | 4 ++-- pkg/amqp-ext/Tests/Functional/AmqpRpcUseCasesTest.php | 4 ++-- .../Tests/ProxyEventDispatcherTest.php | 10 +++++----- pkg/dbal/Tests/DbalContextTest.php | 2 +- pkg/dbal/Tests/Spec/CreateDbalContextTrait.php | 2 +- pkg/enqueue-bundle/EnqueueBundle.php | 6 +++--- .../Tests/Functional/App/CustomAppKernel.php | 2 +- pkg/enqueue-bundle/Tests/Functional/UseCasesTest.php | 4 ++-- .../Compiler/BuildClientExtensionsPassTest.php | 2 +- .../Compiler/BuildConsumptionExtensionsPassTest.php | 2 +- pkg/enqueue/Tests/Rpc/PromiseTest.php | 4 ++-- pkg/null/Tests/NullContextTest.php | 2 +- .../Tests/Functional/SimpleClientTest.php | 4 ++-- pkg/stomp/Tests/Client/StompDriverTest.php | 2 +- pkg/stomp/Tests/Functional/StompCommonUseCasesTest.php | 4 ++-- .../Tests/Functional/StompConsumptionUseCasesTest.php | 4 ++-- pkg/stomp/Tests/Functional/StompRpcUseCasesTest.php | 4 ++-- ...ionTrait.php => RabbitManagementExtensionTrait.php} | 2 +- 35 files changed, 51 insertions(+), 51 deletions(-) rename docs/bundle/{debuging.md => debugging.md} (100%) rename pkg/amqp-bunny/Tests/Spec/{AmqpSendAndReceiveTimestampAsIntengerTest.php => AmqpSendAndReceiveTimestampAsIntegerTest.php} (80%) rename pkg/test/{RabbitmqManagmentExtensionTrait.php => RabbitManagementExtensionTrait.php} (98%) diff --git a/docker-compose.yml b/docker-compose.yml index cf4c3cb2c..01be96cee 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -18,7 +18,7 @@ services: environment: - AMQP_DSN=amqp://guest:guest@rabbitmq:5672/mqdev - AMQPS_DSN=amqps://guest:guest@rabbitmqssl:5671 - - DOCTINE_DSN=mysql://root:rootpass@mysql/mqdev + - DOCTRINE_DSN=mysql://root:rootpass@mysql/mqdev - RABBITMQ_HOST=rabbitmq - RABBITMQ_USER=guest - RABBITMQ_PASSWORD=guest diff --git a/docs/bundle/debuging.md b/docs/bundle/debugging.md similarity index 100% rename from docs/bundle/debuging.md rename to docs/bundle/debugging.md diff --git a/docs/bundle/functional_testing.md b/docs/bundle/functional_testing.md index 0a6dcffee..9950d691e 100644 --- a/docs/bundle/functional_testing.md +++ b/docs/bundle/functional_testing.md @@ -7,7 +7,7 @@ In this chapter we give some advices on how to test message queue related logic. ## NULL transport -While testing the application you dont usually need to send real message to real broker. +While testing the application you don't usually need to send real message to real broker. Or even have a dependency on a MQ broker. Here's the purpose of the NULL transport. It simple do nothing when you ask it to send a message. diff --git a/docs/bundle/job_queue.md b/docs/bundle/job_queue.md index bd37d971e..67ebd8367 100644 --- a/docs/bundle/job_queue.md +++ b/docs/bundle/job_queue.md @@ -75,7 +75,7 @@ $ bin/console doctrine:schema:update Guarantee that there is only one job with such name running at a time. For example you have a task that builds a search index. -It takes quite a lot of time and you dont want another instance of same task working at the same time. +It takes quite a lot of time and you don't want another instance of same task working at the same time. Here's how to do it: * Write a job processor class: diff --git a/docs/client/message_examples.md b/docs/client/message_examples.md index 11e13a100..dfee533af 100644 --- a/docs/client/message_examples.md +++ b/docs/client/message_examples.md @@ -82,7 +82,7 @@ $producer->sendEvent('aTopic', $message); ## Timestamp, Content type, Message id Those are self describing things. -Usually they are set by Client so you dont have to worry about them. +Usually they are set by Client so you don't have to worry about them. If you do not like what Client set you can always set custom values: ```php diff --git a/docs/client/supported_brokers.md b/docs/client/supported_brokers.md index 80f4e87da..3be5dc334 100644 --- a/docs/client/supported_brokers.md +++ b/docs/client/supported_brokers.md @@ -31,6 +31,6 @@ Here's the list of protocols and Client features supported by them * \* Possible if a RabbitMQ delay plugin is installed. * \*\* Possible if topics (exchanges) are configured on broker side manually. -* \*\*\* Possible if RabbitMQ Managment Plugin is installed. +* \*\*\* Possible if RabbitMQ Management Plugin is installed. [back to index](../index.md) diff --git a/docs/consumption/message_processor.md b/docs/consumption/message_processor.md index fe1d30ae5..9492a4c8d 100644 --- a/docs/consumption/message_processor.md +++ b/docs/consumption/message_processor.md @@ -113,7 +113,7 @@ class SendMailProcessor implements PsrProcessor The consumption component provide some useful extensions, for example there is an extension that makes RPC processing simpler. The producer might wait for a reply from a consumer and in order to send it a processor has to return a reply result. -Dont forget to add `ReplyExtension`. +Don't forget to add `ReplyExtension`. ```php bind('foo_queue', function(PsrMessage $message) { - // process messsage + // process message return PsrProcessor::ACK; }); $queueConsumer->bind('bar_queue', function(PsrMessage $message) { - // process messsage + // process message return PsrProcessor::ACK; }); @@ -158,7 +158,7 @@ $queueConsumer->consume(); It provides an easy to use high level abstraction. The goal of the component is hide as much as possible low level details so you can concentrate on things that really matters. -For example, It configure a broker for you by creating queuest, exchanges and bind them. +For example, It configure a broker for you by creating queues, exchanges and bind them. It provides easy to use services for producing and processing messages. It supports unified format for setting message expiration, delay, timestamp, correlation id. It supports [message bus](http://www.enterpriseintegrationpatterns.com/patterns/messaging/MessageBus.html) so different applications can talk to each other. diff --git a/docs/transport/amqp.md b/docs/transport/amqp.md index ac7636604..347e57984 100644 --- a/docs/transport/amqp.md +++ b/docs/transport/amqp.md @@ -181,7 +181,7 @@ $psrContext->createProducer() ## Send delayed message AMQP specification says nothing about message delaying hence the producer throws `DeliveryDelayNotSupportedException`. -Though the producer (and the context) accepts a delivry delay strategy and if it is set it uses it to send delayed message. +Though the producer (and the context) accepts a delivery delay strategy and if it is set it uses it to send delayed message. The `enqueue/amqp-tools` package provides two RabbitMQ delay strategies, to use them you have to install that package ```php diff --git a/docs/transport/amqp_bunny.md b/docs/transport/amqp_bunny.md index 09b59336e..ce064a9ce 100644 --- a/docs/transport/amqp_bunny.md +++ b/docs/transport/amqp_bunny.md @@ -171,7 +171,7 @@ $psrContext->createProducer() ## Send delayed message AMQP specification says nothing about message delaying hence the producer throws `DeliveryDelayNotSupportedException`. -Though the producer (and the context) accepts a delivry delay strategy and if it is set it uses it to send delayed message. +Though the producer (and the context) accepts a delivery delay strategy and if it is set it uses it to send delayed message. The `enqueue/amqp-tools` package provides two RabbitMQ delay strategies, to use them you have to install that package ```php diff --git a/docs/transport/amqp_lib.md b/docs/transport/amqp_lib.md index e1cd3c8db..f7dbcea09 100644 --- a/docs/transport/amqp_lib.md +++ b/docs/transport/amqp_lib.md @@ -179,7 +179,7 @@ $psrContext->createProducer() ## Send delayed message AMQP specification says nothing about message delaying hence the producer throws `DeliveryDelayNotSupportedException`. -Though the producer (and the context) accepts a delivry delay strategy and if it is set it uses it to send delayed message. +Though the producer (and the context) accepts a delivery delay strategy and if it is set it uses it to send delayed message. The `enqueue/amqp-tools` package provides two RabbitMQ delay strategies, to use them you have to install that package ```php diff --git a/docs/transport/kafka.md b/docs/transport/kafka.md index cb36842a5..77006f9d6 100644 --- a/docs/transport/kafka.md +++ b/docs/transport/kafka.md @@ -8,7 +8,7 @@ The transport uses [Kafka](https://kafka.apache.org/) streaming platform as a MQ * [Send message to queue](#send-message-to-queue) * [Consume message](#consume-message) * [Serialize message](#serialize-message) -* [Chnage offset](#change-offset) +* [Change offset](#change-offset) ## Installation diff --git a/pkg/amqp-bunny/Tests/Spec/AmqpSendAndReceiveTimestampAsIntengerTest.php b/pkg/amqp-bunny/Tests/Spec/AmqpSendAndReceiveTimestampAsIntegerTest.php similarity index 80% rename from pkg/amqp-bunny/Tests/Spec/AmqpSendAndReceiveTimestampAsIntengerTest.php rename to pkg/amqp-bunny/Tests/Spec/AmqpSendAndReceiveTimestampAsIntegerTest.php index 2bf30f816..f253d73c9 100644 --- a/pkg/amqp-bunny/Tests/Spec/AmqpSendAndReceiveTimestampAsIntengerTest.php +++ b/pkg/amqp-bunny/Tests/Spec/AmqpSendAndReceiveTimestampAsIntegerTest.php @@ -8,7 +8,7 @@ /** * @group functional */ -class AmqpSendAndReceiveTimestampAsIntengerTest extends SendAndReceiveTimestampAsIntegerSpec +class AmqpSendAndReceiveTimestampAsIntegerTest extends SendAndReceiveTimestampAsIntegerSpec { /** * {@inheritdoc} diff --git a/pkg/amqp-ext/Tests/Functional/AmqpCommonUseCasesTest.php b/pkg/amqp-ext/Tests/Functional/AmqpCommonUseCasesTest.php index ceba5f51c..b5780b472 100644 --- a/pkg/amqp-ext/Tests/Functional/AmqpCommonUseCasesTest.php +++ b/pkg/amqp-ext/Tests/Functional/AmqpCommonUseCasesTest.php @@ -4,7 +4,7 @@ use Enqueue\AmqpExt\AmqpContext; use Enqueue\Test\RabbitmqAmqpExtension; -use Enqueue\Test\RabbitmqManagmentExtensionTrait; +use Enqueue\Test\RabbitManagementExtensionTrait; use Interop\Amqp\Impl\AmqpBind; use Interop\Amqp\Impl\AmqpMessage; use PHPUnit\Framework\TestCase; @@ -15,7 +15,7 @@ class AmqpCommonUseCasesTest extends TestCase { use RabbitmqAmqpExtension; - use RabbitmqManagmentExtensionTrait; + use RabbitManagementExtensionTrait; /** * @var AmqpContext diff --git a/pkg/amqp-ext/Tests/Functional/AmqpConsumptionUseCasesTest.php b/pkg/amqp-ext/Tests/Functional/AmqpConsumptionUseCasesTest.php index 0191bf930..54fccb719 100644 --- a/pkg/amqp-ext/Tests/Functional/AmqpConsumptionUseCasesTest.php +++ b/pkg/amqp-ext/Tests/Functional/AmqpConsumptionUseCasesTest.php @@ -10,7 +10,7 @@ use Enqueue\Consumption\QueueConsumer; use Enqueue\Consumption\Result; use Enqueue\Test\RabbitmqAmqpExtension; -use Enqueue\Test\RabbitmqManagmentExtensionTrait; +use Enqueue\Test\RabbitManagementExtensionTrait; use Interop\Queue\PsrContext; use Interop\Queue\PsrMessage; use Interop\Queue\PsrProcessor; @@ -22,7 +22,7 @@ class AmqpConsumptionUseCasesTest extends TestCase { use RabbitmqAmqpExtension; - use RabbitmqManagmentExtensionTrait; + use RabbitManagementExtensionTrait; /** * @var AmqpContext diff --git a/pkg/amqp-ext/Tests/Functional/AmqpRpcUseCasesTest.php b/pkg/amqp-ext/Tests/Functional/AmqpRpcUseCasesTest.php index 3db7ec63c..ba8838602 100644 --- a/pkg/amqp-ext/Tests/Functional/AmqpRpcUseCasesTest.php +++ b/pkg/amqp-ext/Tests/Functional/AmqpRpcUseCasesTest.php @@ -6,7 +6,7 @@ use Enqueue\Rpc\Promise; use Enqueue\Rpc\RpcClient; use Enqueue\Test\RabbitmqAmqpExtension; -use Enqueue\Test\RabbitmqManagmentExtensionTrait; +use Enqueue\Test\RabbitManagementExtensionTrait; use Interop\Amqp\Impl\AmqpMessage; use PHPUnit\Framework\TestCase; @@ -16,7 +16,7 @@ class AmqpRpcUseCasesTest extends TestCase { use RabbitmqAmqpExtension; - use RabbitmqManagmentExtensionTrait; + use RabbitManagementExtensionTrait; /** * @var AmqpContext diff --git a/pkg/async-event-dispatcher/Tests/ProxyEventDispatcherTest.php b/pkg/async-event-dispatcher/Tests/ProxyEventDispatcherTest.php index 5e5c6e969..7c8319147 100644 --- a/pkg/async-event-dispatcher/Tests/ProxyEventDispatcherTest.php +++ b/pkg/async-event-dispatcher/Tests/ProxyEventDispatcherTest.php @@ -20,7 +20,7 @@ public function testShouldBeSubClassOfEventDispatcher() public function testShouldSetSyncModeForGivenEventNameOnDispatchAsyncListenersOnly() { - $asyncListenerMock = $this->createAsyncLisenerMock(); + $asyncListenerMock = $this->createAsyncListenerMock(); $asyncListenerMock ->expects($this->once()) ->method('resetSyncMode') @@ -49,7 +49,7 @@ public function testShouldCallAsyncEventButNotOtherOnDispatchAsyncListenersOnly( }); $asyncEventWasCalled = false; - $dispatcher = new AsyncEventDispatcher($trueEventDispatcher, $this->createAsyncLisenerMock()); + $dispatcher = new AsyncEventDispatcher($trueEventDispatcher, $this->createAsyncListenerMock()); $dispatcher->addListener('theEvent', function () use (&$asyncEventWasCalled) { $this->assertInstanceOf(AsyncEventDispatcher::class, func_get_arg(2)); @@ -74,7 +74,7 @@ public function testShouldCallOtherEventIfDispatchedFromAsyncEventOnDispatchAsyn }); $asyncEventWasCalled = false; - $dispatcher = new AsyncEventDispatcher($trueEventDispatcher, $this->createAsyncLisenerMock()); + $dispatcher = new AsyncEventDispatcher($trueEventDispatcher, $this->createAsyncListenerMock()); $dispatcher->addListener('theEvent', function () use (&$asyncEventWasCalled) { $this->assertInstanceOf(AsyncEventDispatcher::class, func_get_arg(2)); @@ -97,7 +97,7 @@ public function testShouldNotCallAsyncEventIfDispatchedFromOtherEventOnDispatchA func_get_arg(2)->dispatch('theOtherAsyncEvent'); }); - $dispatcher = new AsyncEventDispatcher($trueEventDispatcher, $this->createAsyncLisenerMock()); + $dispatcher = new AsyncEventDispatcher($trueEventDispatcher, $this->createAsyncListenerMock()); $dispatcher->addListener('theAsyncEvent', function () { func_get_arg(2)->dispatch('theOtherEvent'); }); @@ -115,7 +115,7 @@ public function testShouldNotCallAsyncEventIfDispatchedFromOtherEventOnDispatchA /** * @return \PHPUnit_Framework_MockObject_MockObject|AsyncListener */ - private function createAsyncLisenerMock() + private function createAsyncListenerMock() { return $this->createMock(AsyncListener::class); } diff --git a/pkg/dbal/Tests/DbalContextTest.php b/pkg/dbal/Tests/DbalContextTest.php index 746a4f83d..88fb11990 100644 --- a/pkg/dbal/Tests/DbalContextTest.php +++ b/pkg/dbal/Tests/DbalContextTest.php @@ -135,7 +135,7 @@ public function testShouldReturnConfig() $this->assertSame($connection, $context->getDbalConnection()); } - public function testShouldThrowBadMethodCallExceptiOnOncreateTemporaryQueueCall() + public function testShouldThrowBadMethodCallExceptionOncreateTemporaryQueueCall() { $context = new DbalContext($connection = $this->createConnectionMock()); diff --git a/pkg/dbal/Tests/Spec/CreateDbalContextTrait.php b/pkg/dbal/Tests/Spec/CreateDbalContextTrait.php index d4c954afb..15c1f75e4 100644 --- a/pkg/dbal/Tests/Spec/CreateDbalContextTrait.php +++ b/pkg/dbal/Tests/Spec/CreateDbalContextTrait.php @@ -8,7 +8,7 @@ trait CreateDbalContextTrait { protected function createDbalContext() { - if (false == $env = getenv('DOCTINE_DSN')) { + if (false == $env = getenv('DOCTRINE_DSN')) { $this->markTestSkipped('The DOCTRINE_DSN env is not available. Skip tests'); } diff --git a/pkg/enqueue-bundle/EnqueueBundle.php b/pkg/enqueue-bundle/EnqueueBundle.php index b22e55250..e007b97dc 100644 --- a/pkg/enqueue-bundle/EnqueueBundle.php +++ b/pkg/enqueue-bundle/EnqueueBundle.php @@ -69,9 +69,9 @@ class_exists(AmqpLibConnectionFactory::class) $extension->setTransportFactory(new AmqpTransportFactory('amqp')); $extension->setTransportFactory(new RabbitMqAmqpTransportFactory('rabbitmq_amqp')); } else { - $amppPackages = ['enqueue/amqp-ext', 'enqueue/amqp-bunny', 'enqueue/amqp-lib']; - $extension->setTransportFactory(new MissingTransportFactory('amqp', $amppPackages)); - $extension->setTransportFactory(new MissingTransportFactory('rabbitmq_amqp', $amppPackages)); + $amqpPackages = ['enqueue/amqp-ext', 'enqueue/amqp-bunny', 'enqueue/amqp-lib']; + $extension->setTransportFactory(new MissingTransportFactory('amqp', $amqpPackages)); + $extension->setTransportFactory(new MissingTransportFactory('rabbitmq_amqp', $amqpPackages)); } if (class_exists(FsConnectionFactory::class)) { diff --git a/pkg/enqueue-bundle/Tests/Functional/App/CustomAppKernel.php b/pkg/enqueue-bundle/Tests/Functional/App/CustomAppKernel.php index 574dc6b39..465196149 100644 --- a/pkg/enqueue-bundle/Tests/Functional/App/CustomAppKernel.php +++ b/pkg/enqueue-bundle/Tests/Functional/App/CustomAppKernel.php @@ -28,7 +28,7 @@ class CustomAppKernel extends Kernel public function setEnqueueConfig(array $config) { $this->enqueueConfig = array_replace_recursive($this->enqueueConfig, $config); - $this->enqueueConfig['client']['app_name'] = str_replace('.', '', uniqid(true)); + $this->enqueueConfig['client']['app_name'] = str_replace('.', '', uniqid('app_name', true)); $this->enqueueConfigId = md5(json_encode($this->enqueueConfig)); $fs = new Filesystem(); diff --git a/pkg/enqueue-bundle/Tests/Functional/UseCasesTest.php b/pkg/enqueue-bundle/Tests/Functional/UseCasesTest.php index db9768ed1..cec646a7c 100644 --- a/pkg/enqueue-bundle/Tests/Functional/UseCasesTest.php +++ b/pkg/enqueue-bundle/Tests/Functional/UseCasesTest.php @@ -104,7 +104,7 @@ public function provideEnqueueConfigs() yield 'default_dbal_as_dsn' => [[ 'transport' => [ - 'default' => getenv('DOCTINE_DSN'), + 'default' => getenv('DOCTRINE_DSN'), ], ]]; @@ -188,7 +188,7 @@ public function provideEnqueueConfigs() yield 'dbal_dsn' => [[ 'transport' => [ 'default' => 'dbal', - 'dbal' => getenv('DOCTINE_DSN'), + 'dbal' => getenv('DOCTRINE_DSN'), ], ]]; diff --git a/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildClientExtensionsPassTest.php b/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildClientExtensionsPassTest.php index 516cfa553..e98184b84 100644 --- a/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildClientExtensionsPassTest.php +++ b/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildClientExtensionsPassTest.php @@ -24,7 +24,7 @@ public function testCouldBeConstructedWithoutAnyArguments() new BuildClientExtensionsPass(); } - public function testShouldReplaceFirstArgumentOfExtensionsServiceConstructorWithTaggsExtensions() + public function testShouldReplaceFirstArgumentOfExtensionsServiceConstructorWithTagsExtensions() { $container = new ContainerBuilder(); diff --git a/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildConsumptionExtensionsPassTest.php b/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildConsumptionExtensionsPassTest.php index 75d3759a7..a7614bc96 100644 --- a/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildConsumptionExtensionsPassTest.php +++ b/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/Compiler/BuildConsumptionExtensionsPassTest.php @@ -24,7 +24,7 @@ public function testCouldBeConstructedWithoutAnyArguments() new BuildConsumptionExtensionsPass(); } - public function testShouldReplaceFirstArgumentOfExtensionsServiceConstructorWithTaggsExtensions() + public function testShouldReplaceFirstArgumentOfExtensionsServiceConstructorWithTagsExtensions() { $container = new ContainerBuilder(); diff --git a/pkg/enqueue/Tests/Rpc/PromiseTest.php b/pkg/enqueue/Tests/Rpc/PromiseTest.php index b2cb42a13..7202e67fc 100644 --- a/pkg/enqueue/Tests/Rpc/PromiseTest.php +++ b/pkg/enqueue/Tests/Rpc/PromiseTest.php @@ -31,10 +31,10 @@ public function testOnReceiveShouldCallReceiveCallBack() $receiveInvoked = false; $receivePromise = null; $receiveTimeout = null; - $receivecb = function ($promise, $timout) use (&$receiveInvoked, &$receivePromise, &$receiveTimeout) { + $receivecb = function ($promise, $timeout) use (&$receiveInvoked, &$receivePromise, &$receiveTimeout) { $receiveInvoked = true; $receivePromise = $promise; - $receiveTimeout = $timout; + $receiveTimeout = $timeout; }; $promise = new Promise($receivecb, function () {}, function () {}); diff --git a/pkg/null/Tests/NullContextTest.php b/pkg/null/Tests/NullContextTest.php index 921734c83..a17f42aa9 100644 --- a/pkg/null/Tests/NullContextTest.php +++ b/pkg/null/Tests/NullContextTest.php @@ -90,7 +90,7 @@ public function testShouldAllowCreateProducer() $this->assertInstanceOf(NullProducer::class, $producer); } - public function testShouldCreateTempraryQueueWithUnqiueName() + public function testShouldCreateTemporaryQueueWithUniqueName() { $context = new NullContext(); diff --git a/pkg/simple-client/Tests/Functional/SimpleClientTest.php b/pkg/simple-client/Tests/Functional/SimpleClientTest.php index cedbd11ff..75d508c8d 100644 --- a/pkg/simple-client/Tests/Functional/SimpleClientTest.php +++ b/pkg/simple-client/Tests/Functional/SimpleClientTest.php @@ -8,7 +8,7 @@ use Enqueue\Consumption\Result; use Enqueue\SimpleClient\SimpleClient; use Enqueue\Test\RabbitmqAmqpExtension; -use Enqueue\Test\RabbitmqManagmentExtensionTrait; +use Enqueue\Test\RabbitManagementExtensionTrait; use Interop\Queue\PsrMessage; use PHPUnit\Framework\TestCase; @@ -18,7 +18,7 @@ class SimpleClientTest extends TestCase { use RabbitmqAmqpExtension; - use RabbitmqManagmentExtensionTrait; + use RabbitManagementExtensionTrait; public function setUp() { diff --git a/pkg/stomp/Tests/Client/StompDriverTest.php b/pkg/stomp/Tests/Client/StompDriverTest.php index 187f31c0c..029d275ef 100644 --- a/pkg/stomp/Tests/Client/StompDriverTest.php +++ b/pkg/stomp/Tests/Client/StompDriverTest.php @@ -277,7 +277,7 @@ public function testShouldThrowExceptionIfProcessorQueueNameParameterIsNotSet() $driver->sendToProcessor($message); } - public function testSetupBrokerShouldOnlyLogMessageThatStompDoesNotSupprtBrokerSetup() + public function testSetupBrokerShouldOnlyLogMessageThatStompDoesNotSupportBrokerSetup() { $driver = new StompDriver( $this->createPsrContextMock(), diff --git a/pkg/stomp/Tests/Functional/StompCommonUseCasesTest.php b/pkg/stomp/Tests/Functional/StompCommonUseCasesTest.php index eb0a11b78..19af898a6 100644 --- a/pkg/stomp/Tests/Functional/StompCommonUseCasesTest.php +++ b/pkg/stomp/Tests/Functional/StompCommonUseCasesTest.php @@ -4,7 +4,7 @@ use Enqueue\Stomp\StompContext; use Enqueue\Stomp\StompMessage; -use Enqueue\Test\RabbitmqManagmentExtensionTrait; +use Enqueue\Test\RabbitManagementExtensionTrait; use Enqueue\Test\RabbitmqStompExtension; /** @@ -13,7 +13,7 @@ class StompCommonUseCasesTest extends \PHPUnit\Framework\TestCase { use RabbitmqStompExtension; - use RabbitmqManagmentExtensionTrait; + use RabbitManagementExtensionTrait; /** * @var StompContext diff --git a/pkg/stomp/Tests/Functional/StompConsumptionUseCasesTest.php b/pkg/stomp/Tests/Functional/StompConsumptionUseCasesTest.php index 5bfd73a83..0c6de93f5 100644 --- a/pkg/stomp/Tests/Functional/StompConsumptionUseCasesTest.php +++ b/pkg/stomp/Tests/Functional/StompConsumptionUseCasesTest.php @@ -9,7 +9,7 @@ use Enqueue\Consumption\QueueConsumer; use Enqueue\Consumption\Result; use Enqueue\Stomp\StompContext; -use Enqueue\Test\RabbitmqManagmentExtensionTrait; +use Enqueue\Test\RabbitManagementExtensionTrait; use Enqueue\Test\RabbitmqStompExtension; use Interop\Queue\PsrContext; use Interop\Queue\PsrMessage; @@ -21,7 +21,7 @@ class StompConsumptionUseCasesTest extends \PHPUnit\Framework\TestCase { use RabbitmqStompExtension; - use RabbitmqManagmentExtensionTrait; + use RabbitManagementExtensionTrait; /** * @var StompContext diff --git a/pkg/stomp/Tests/Functional/StompRpcUseCasesTest.php b/pkg/stomp/Tests/Functional/StompRpcUseCasesTest.php index 3ece5e486..4e4e8385a 100644 --- a/pkg/stomp/Tests/Functional/StompRpcUseCasesTest.php +++ b/pkg/stomp/Tests/Functional/StompRpcUseCasesTest.php @@ -6,7 +6,7 @@ use Enqueue\Rpc\RpcClient; use Enqueue\Stomp\StompContext; use Enqueue\Stomp\StompMessage; -use Enqueue\Test\RabbitmqManagmentExtensionTrait; +use Enqueue\Test\RabbitManagementExtensionTrait; use Enqueue\Test\RabbitmqStompExtension; /** @@ -15,7 +15,7 @@ class StompRpcUseCasesTest extends \PHPUnit\Framework\TestCase { use RabbitmqStompExtension; - use RabbitmqManagmentExtensionTrait; + use RabbitManagementExtensionTrait; /** * @var StompContext diff --git a/pkg/test/RabbitmqManagmentExtensionTrait.php b/pkg/test/RabbitManagementExtensionTrait.php similarity index 98% rename from pkg/test/RabbitmqManagmentExtensionTrait.php rename to pkg/test/RabbitManagementExtensionTrait.php index 660e20d58..c7665882a 100644 --- a/pkg/test/RabbitmqManagmentExtensionTrait.php +++ b/pkg/test/RabbitManagementExtensionTrait.php @@ -2,7 +2,7 @@ namespace Enqueue\Test; -trait RabbitmqManagmentExtensionTrait +trait RabbitManagementExtensionTrait { /** * @param string $queueName From d24ea5b4154f55dea1617af1ed8b53f22f5a4c97 Mon Sep 17 00:00:00 2001 From: Bas Date: Mon, 26 Mar 2018 11:14:22 +0200 Subject: [PATCH 07/11] Fix AMQP(s) code in amqp.md --- docs/transport/amqp.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/transport/amqp.md b/docs/transport/amqp.md index ac7636604..126ff9f6d 100644 --- a/docs/transport/amqp.md +++ b/docs/transport/amqp.md @@ -78,7 +78,7 @@ use Interop\Amqp\AmqpTopic; /** @var \Enqueue\AmqpExt\AmqpContext $psrContext */ $fooTopic = $psrContext->createTopic('foo'); -$fooTopic->addFlag(AmqpTopic::TYPE_FANOUT); +$fooTopic->setType(AmqpTopic::TYPE_FANOUT); $psrContext->declareTopic($fooTopic); // to remove topic use delete topic method From 442f995e7f4f6fa158052ade072cd1e08f2447eb Mon Sep 17 00:00:00 2001 From: Maksim Kotlyar Date: Tue, 27 Mar 2018 08:45:37 +0300 Subject: [PATCH 08/11] fix cs --- pkg/amqp-ext/Tests/Functional/AmqpRpcUseCasesTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/amqp-ext/Tests/Functional/AmqpRpcUseCasesTest.php b/pkg/amqp-ext/Tests/Functional/AmqpRpcUseCasesTest.php index ba8838602..bbc94423a 100644 --- a/pkg/amqp-ext/Tests/Functional/AmqpRpcUseCasesTest.php +++ b/pkg/amqp-ext/Tests/Functional/AmqpRpcUseCasesTest.php @@ -5,8 +5,8 @@ use Enqueue\AmqpExt\AmqpContext; use Enqueue\Rpc\Promise; use Enqueue\Rpc\RpcClient; -use Enqueue\Test\RabbitmqAmqpExtension; use Enqueue\Test\RabbitManagementExtensionTrait; +use Enqueue\Test\RabbitmqAmqpExtension; use Interop\Amqp\Impl\AmqpMessage; use PHPUnit\Framework\TestCase; From 09b5c482af16650fba15f04958147862f6803a2f Mon Sep 17 00:00:00 2001 From: Maksim Kotlyar Date: Tue, 27 Mar 2018 09:06:16 +0300 Subject: [PATCH 09/11] fix cs --- pkg/amqp-ext/Tests/Functional/AmqpCommonUseCasesTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/amqp-ext/Tests/Functional/AmqpCommonUseCasesTest.php b/pkg/amqp-ext/Tests/Functional/AmqpCommonUseCasesTest.php index b5780b472..294248e4e 100644 --- a/pkg/amqp-ext/Tests/Functional/AmqpCommonUseCasesTest.php +++ b/pkg/amqp-ext/Tests/Functional/AmqpCommonUseCasesTest.php @@ -3,8 +3,8 @@ namespace Enqueue\AmqpExt\Tests\Functional; use Enqueue\AmqpExt\AmqpContext; -use Enqueue\Test\RabbitmqAmqpExtension; use Enqueue\Test\RabbitManagementExtensionTrait; +use Enqueue\Test\RabbitmqAmqpExtension; use Interop\Amqp\Impl\AmqpBind; use Interop\Amqp\Impl\AmqpMessage; use PHPUnit\Framework\TestCase; From df5e4bfc79fad046b2acffc7b32c2ab4ab175e30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ram=C5=ABnas=20Dronga?= Date: Tue, 27 Mar 2018 10:10:59 +0300 Subject: [PATCH 10/11] [bundle] Don't ping DBAL connection if it wasn't opened --- .../DoctrinePingConnectionExtension.php | 4 ++ .../DoctrinePingConnectionExtensionTest.php | 53 +++++++++++++++++++ 2 files changed, 57 insertions(+) diff --git a/pkg/enqueue-bundle/Consumption/Extension/DoctrinePingConnectionExtension.php b/pkg/enqueue-bundle/Consumption/Extension/DoctrinePingConnectionExtension.php index 6f3770ee8..5ca804df1 100644 --- a/pkg/enqueue-bundle/Consumption/Extension/DoctrinePingConnectionExtension.php +++ b/pkg/enqueue-bundle/Consumption/Extension/DoctrinePingConnectionExtension.php @@ -32,6 +32,10 @@ public function onPreReceived(Context $context) { /** @var Connection $connection */ foreach ($this->registry->getConnections() as $connection) { + if (!$connection->isConnected()) { + continue; + } + if ($connection->ping()) { return; } diff --git a/pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/DoctrinePingConnectionExtensionTest.php b/pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/DoctrinePingConnectionExtensionTest.php index cb15656f3..acc23bc4e 100644 --- a/pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/DoctrinePingConnectionExtensionTest.php +++ b/pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/DoctrinePingConnectionExtensionTest.php @@ -22,6 +22,11 @@ public function testCouldBeConstructedWithRequiredAttributes() public function testShouldNotReconnectIfConnectionIsOK() { $connection = $this->createConnectionMock(); + $connection + ->expects($this->once()) + ->method('isConnected') + ->will($this->returnValue(true)) + ; $connection ->expects($this->once()) ->method('ping') @@ -56,6 +61,11 @@ public function testShouldNotReconnectIfConnectionIsOK() public function testShouldDoesReconnectIfConnectionFailed() { $connection = $this->createConnectionMock(); + $connection + ->expects($this->once()) + ->method('isConnected') + ->will($this->returnValue(true)) + ; $connection ->expects($this->once()) ->method('ping') @@ -93,6 +103,49 @@ public function testShouldDoesReconnectIfConnectionFailed() $extension->onPreReceived($context); } + public function testShouldSkipIfConnectionWasNotOpened() + { + $connection1 = $this->createConnectionMock(); + $connection1 + ->expects($this->once()) + ->method('isConnected') + ->will($this->returnValue(false)) + ; + $connection1 + ->expects($this->never()) + ->method('ping') + ; + + // 2nd connection was opened in the past + $connection2 = $this->createConnectionMock(); + $connection2 + ->expects($this->once()) + ->method('isConnected') + ->will($this->returnValue(true)) + ; + $connection2 + ->expects($this->once()) + ->method('ping') + ->will($this->returnValue(true)) + ; + + $context = $this->createPsrContext(); + $context->getLogger() + ->expects($this->never()) + ->method('debug') + ; + + $registry = $this->createRegistryMock(); + $registry + ->expects($this->once()) + ->method('getConnections') + ->will($this->returnValue([$connection1, $connection2])) + ; + + $extension = new DoctrinePingConnectionExtension($registry); + $extension->onPreReceived($context); + } + /** * @return Context */ From 1ee65deb524d1e5f57903e15a9729f54096d448f Mon Sep 17 00:00:00 2001 From: Maksim Kotlyar Date: Tue, 27 Mar 2018 12:54:21 +0300 Subject: [PATCH 11/11] Release 0.8.24 --- CHANGELOG.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5fb788c1f..2eaaff221 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,21 @@ # Change Log +## [0.8.24](https://github.com/php-enqueue/enqueue-dev/tree/0.8.24) (2018-03-27) +[Full Changelog](https://github.com/php-enqueue/enqueue-dev/compare/0.8.23...0.8.24) + +- \[fs\] Escape special symbols [\#390](https://github.com/php-enqueue/enqueue-dev/issues/390) +- \[fs\] Escape delimiter symbols. [\#402](https://github.com/php-enqueue/enqueue-dev/pull/402) ([makasim](https://github.com/makasim)) + +- Laravel Usage [\#408](https://github.com/php-enqueue/enqueue-dev/issues/408) +- \[JobRunner\] Uncaught exceptions leave jobs in "running" state [\#385](https://github.com/php-enqueue/enqueue-dev/issues/385) +- \[Feature Request\] Closure message body. [\#366](https://github.com/php-enqueue/enqueue-dev/issues/366) + +- \[bundle\] Don't ping DBAL connection if it wasn't opened [\#414](https://github.com/php-enqueue/enqueue-dev/pull/414) ([ramunasd](https://github.com/ramunasd)) +- Fix AMQP\(s\) code in amqp.md [\#413](https://github.com/php-enqueue/enqueue-dev/pull/413) ([xdbas](https://github.com/xdbas)) +- Fixed typos [\#412](https://github.com/php-enqueue/enqueue-dev/pull/412) ([pborreli](https://github.com/pborreli)) +- Fixed typo [\#411](https://github.com/php-enqueue/enqueue-dev/pull/411) ([pborreli](https://github.com/pborreli)) +- Update sqs transport factory with missing endpoint parameter [\#404](https://github.com/php-enqueue/enqueue-dev/pull/404) ([asilgalis](https://github.com/asilgalis)) + ## [0.8.23](https://github.com/php-enqueue/enqueue-dev/tree/0.8.23) (2018-03-06) [Full Changelog](https://github.com/php-enqueue/enqueue-dev/compare/0.8.22...0.8.23)