Añadidos tests salida correcta y nula

Author: Delacruz-6

src/main/java/com/sopromadze/blogapi/controller/AlbumController.java

@@ -57,7 +57,8 @@ public PagedResponse<AlbumResponse> getAllAlbums(
 	@PostMapping
 	@PreAuthorize("hasRole('USER')")
 	public ResponseEntity<Album> addAlbum(@Valid @RequestBody AlbumRequest albumRequest, @CurrentUser UserPrincipal currentUser) {
-		return albumService.addAlbum(albumRequest, currentUser);
+		return ResponseEntity.status(HttpStatus.CREATED).body(albumService.addAlbum(albumRequest, currentUser));
+
 	}
 
 	@GetMapping("/{id}")

src/main/java/com/sopromadze/blogapi/service/AlbumService.java

@@ -12,7 +12,7 @@ public interface AlbumService {
 
 	PagedResponse<AlbumResponse> getAllAlbums(int page, int size);
 
-	ResponseEntity<Album> addAlbum(AlbumRequest albumRequest, UserPrincipal currentUser);
+	Album addAlbum(AlbumRequest albumRequest, UserPrincipal currentUser);
 
 	ResponseEntity<Album> getAlbum(Long id);
 

src/main/java/com/sopromadze/blogapi/service/impl/AlbumServiceImpl.java

@@ -68,16 +68,16 @@ public PagedResponse<AlbumResponse> getAllAlbums(int page, int size) {
 	}
 
 	@Override
-	public ResponseEntity<Album> addAlbum(AlbumRequest albumRequest, UserPrincipal currentUser) {
+	public Album addAlbum(AlbumRequest albumRequest, UserPrincipal currentUser) {
 		User user = userRepository.getUser(currentUser);
 
 		Album album = new Album();
 
 		modelMapper.map(albumRequest, album);
 
 		album.setUser(user);
-		Album newAlbum = albumRepository.save(album);
-		return new ResponseEntity<>(newAlbum, HttpStatus.CREATED);
+
+		return albumRepository.save(album);
 	}
 
 	@Override

src/test/java/com/sopromadze/blogapi/serviceTest/album/AddAlbum.java

@@ -0,0 +1,85 @@
+package com.sopromadze.blogapi.serviceTest.album;
+
+
+import com.sopromadze.blogapi.model.Album;
+import com.sopromadze.blogapi.model.user.User;
+import com.sopromadze.blogapi.payload.request.AlbumRequest;
+import com.sopromadze.blogapi.repository.AlbumRepository;
+import com.sopromadze.blogapi.repository.UserRepository;
+import com.sopromadze.blogapi.security.UserPrincipal;
+import com.sopromadze.blogapi.service.impl.AlbumServiceImpl;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.NullAndEmptySource;
+import org.junit.jupiter.params.provider.NullSource;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.mockito.junit.jupiter.MockitoSettings;
+import org.mockito.quality.Strictness;
+import org.modelmapper.ModelMapper;
+
+import java.util.Collections;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.when;
+
+@ExtendWith (MockitoExtension.class)
+@MockitoSettings (strictness = Strictness.LENIENT)
+public class AddAlbum {
+
+    @Mock
+    private AlbumRepository albumRepository;
+
+    @Mock
+    private UserRepository userRepository;
+
+    @Mock
+    private ModelMapper modelMapper;
+
+    @InjectMocks
+    AlbumServiceImpl albumService;
+
+    /*
+        Test:               Comprobar se añade un usuario a un nuevo album
+        Entrada:            albumService.addAlbum(albumRequest,userPrincipal
+        Salida esperada:    El test se realiza con exito
+    */
+    @DisplayName("add Album to User")
+    @Test
+    void addAlbum_Success() {
+        User user = new User("Pepe","Garcia", "Sony777","sony777@gmail.com","1234");
+        user.setId(1L);
+
+        UserPrincipal userPrincipal = new UserPrincipal(1L,"Pepe","Garcia", "Sony777","sony777@gmail.com","1234", Collections.emptyList());
+        when(userRepository.getUserByName(userPrincipal.getUsername())).thenReturn(user);
+        Album album = new Album();
+        AlbumRequest albumRequest= new AlbumRequest();
+        album.setUser(userRepository.getUser(userPrincipal));
+        when(albumRepository.save(album)).thenReturn(album);
+
+        assertEquals(albumService.addAlbum(albumRequest,userPrincipal),album);
+
+    }
+
+    /*
+        Test:               Comprobar se añade un usuario a un nuevo album
+        Entrada:            albumService.addAlbum(albumRequest,userPrincipal)
+        Salida esperada:    La respuesta deberia ser nula siendo el usuarioPrincipal nulo
+    */
+    @DisplayName("Not added Album to User (null)")
+    @ParameterizedTest
+    @NullSource
+    void addAlbum_SuccessWhenNull(UserPrincipal userPrincipal) {
+
+        User user = new User();
+        Album album = new Album();
+        AlbumRequest albumRequest= new AlbumRequest();
+        album.setUser(user);
+        assertNull(albumService.addAlbum(albumRequest,userPrincipal));
+
+    }
+}