Tests for repository > PostRepository > findByCategoryId:

Previously called findByCategory, changed for causing a wrong query.

Author: navalcode

src/main/java/com/sopromadze/blogapi/repository/PostRepository.java

@@ -13,7 +13,7 @@
 public interface PostRepository extends JpaRepository<Post, Long> {
 	Page<Post> findByCreatedBy(Long userId, Pageable pageable);
 
-	Page<Post> findByCategory(Long categoryId, Pageable pageable);
+	Page<Post> findByCategoryId(Long categoryId, Pageable pageable);
 
 	Page<Post> findByTagsIn(List<Tag> tags, Pageable pageable);
 

src/main/java/com/sopromadze/blogapi/service/impl/PostServiceImpl.java

@@ -86,7 +86,7 @@ public PagedResponse<Post> getPostsByCategory(Long id, int page, int size) {
 				.orElseThrow(() -> new ResourceNotFoundException(CATEGORY, ID, id));
 
 		Pageable pageable = PageRequest.of(page, size, Sort.Direction.DESC, CREATED_AT);
-		Page<Post> posts = postRepository.findByCategory(category.getId(), pageable);
+		Page<Post> posts = postRepository.findByCategoryId(category.getId(), pageable);
 
 		List<Post> content = posts.getNumberOfElements() == 0 ? Collections.emptyList() : posts.getContent();
 

src/test/java/com/sopromadze/blogapi/repositoryTest/post/FindByCategoryTest.java

@@ -0,0 +1,108 @@
+package com.sopromadze.blogapi.repositoryTest.post;
+
+import com.sopromadze.blogapi.model.Category;
+import com.sopromadze.blogapi.model.Comment;
+import com.sopromadze.blogapi.model.Post;
+import com.sopromadze.blogapi.model.Tag;
+import com.sopromadze.blogapi.model.user.User;
+import com.sopromadze.blogapi.repository.PostRepository;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.autoconfigure.jdbc.AutoConfigureTestDatabase;
+import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
+import org.springframework.boot.test.autoconfigure.orm.jpa.TestEntityManager;
+import org.springframework.data.domain.Page;
+import org.springframework.data.domain.PageRequest;
+import org.springframework.data.domain.Pageable;
+import org.springframework.data.domain.Sort;
+import org.springframework.test.context.ActiveProfiles;
+
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+import static com.sopromadze.blogapi.utils.AppConstants.CREATED_AT;
+
+@DataJpaTest
+@ActiveProfiles("test")
+@AutoConfigureTestDatabase(replace= AutoConfigureTestDatabase.Replace.NONE)
+public class FindByCategoryTest {
+
+    @Autowired
+    private PostRepository postRepository;
+
+    @Autowired
+    private TestEntityManager testEntityManager;
+
+    @BeforeEach
+    void init(){
+        //Category creation
+        Category ca = new Category("category");
+        ca.setCreatedAt(Instant.now());
+        ca.setUpdatedAt(Instant.now());
+
+        //Post creation
+        Post p= new Post();
+        p.setCategory(ca);
+        p.setCreatedAt(Instant.now());
+        p.setUpdatedAt(Instant.now());
+        p.setTitle("post");
+        p.setBody("body");
+
+        //Comments creation
+        List<Comment> coments= new ArrayList<Comment>();
+        p.setComments(coments);
+
+        //User creation
+        User user = new User();
+        user.setEmail("user@email.com");
+        user.setFirstName("FirstName");
+        user.setUsername("UserName");
+        user.setLastName("LastName");
+        user.setPassword("password");
+        user.setCreatedAt(Instant.now());
+        user.setUpdatedAt(Instant.now());
+
+        p.setUser(user);
+        List<Tag> tgs= new ArrayList<Tag>();
+        p.setTags(tgs);
+        List<Post> lp= new ArrayList<Post>();
+
+        testEntityManager.persist(p);
+        testEntityManager.persist(ca);
+        testEntityManager.persist(user);
+    }
+
+    //Test: Find by category id.
+    //Entrada: Long categoryId, Pageable
+    //Salida esperada: Page<post from category name>
+    @Test
+    @DisplayName("Find by category")
+    void findByCateogy_success(){
+
+        Pageable pageable = PageRequest.of(1, 25, Sort.Direction.DESC, CREATED_AT);
+
+        Page<Post> result =postRepository.findByCategoryId(1L,pageable);
+
+        assertTrue(result.getTotalElements()!=0);
+    }
+
+    //Test: Find by non-existent category .
+    //Entrada: Long categoryId, Pageable
+    //Salida esperada:  page with no elements
+    @Test
+    @DisplayName("Find by non-existent category")
+    void findByCateogy_fail(){
+
+        Pageable pageable = PageRequest.of(1, 25, Sort.Direction.DESC, CREATED_AT);
+
+        Page<Post> result =postRepository.findByCategoryId(0L,pageable);
+
+        assertFalse(result.getTotalElements()!=0);
+    }
+}

src/test/java/com/sopromadze/blogapi/repositoryTest/todo/FindByCreatedByTest.java

@@ -0,0 +1,4 @@
+package com.sopromadze.blogapi.repositoryTest.todo;
+
+public class FindByCreatedByTest {
+}