From ef4ef3be389153d68cba7e6e7f740c75dedc33db Mon Sep 17 00:00:00 2001 From: "melodic-automation-lanes[bot]" <337595936+melodic-automation-lanes[bot]@users.noreply.github.com> Date: Sun, 25 Oct 2026 19:56:44 +0000 Subject: [PATCH] Resolve issue #9685 Lane-Activity: work-resolve-issue/resolve-issue --- .../fix-9685-python-3-14-ceiling-7d2e4b19.md | 7 ++++++ lib/prerequisites.test.mjs | 22 ++++++++++++++++++- plugins/explainer-video/prerequisites.json | 2 +- 3 files changed, 29 insertions(+), 2 deletions(-) create mode 100644 .changes/explainer-video/fix-9685-python-3-14-ceiling-7d2e4b19.md diff --git a/.changes/explainer-video/fix-9685-python-3-14-ceiling-7d2e4b19.md b/.changes/explainer-video/fix-9685-python-3-14-ceiling-7d2e4b19.md new file mode 100644 index 00000000000..888d229c9d3 --- /dev/null +++ b/.changes/explainer-video/fix-9685-python-3-14-ceiling-7d2e4b19.md @@ -0,0 +1,7 @@ +--- +bump: patch +--- + +### Fixed + +- `prerequisites.json` caps the `python` entry with `below: "3.14"`, so a host whose only Python is 3.14 is reported outdated instead of ready. The install hook runs only on Python 3.12 or 3.13. diff --git a/lib/prerequisites.test.mjs b/lib/prerequisites.test.mjs index db56ca42d79..5a9b54406ae 100644 --- a/lib/prerequisites.test.mjs +++ b/lib/prerequisites.test.mjs @@ -15,7 +15,17 @@ import path from "node:path"; import process from "node:process"; import { after, describe, test } from "node:test"; import { fileURLToPath } from "node:url"; -import { compareVersions, KINDS, loadManifest, main, NEEDS, report, validateManifest, which } from "./prerequisites.mjs"; +import { + compareVersions, + detectEntry, + KINDS, + loadManifest, + main, + NEEDS, + report, + validateManifest, + which, +} from "./prerequisites.mjs"; const here = path.dirname(fileURLToPath(import.meta.url)); const checker = path.join(here, "prerequisites.mjs"); @@ -897,6 +907,16 @@ describe("shipped plugin manifests", { skip: !posix && "the stub tools are POSIX assert.equal(r.out, ""); }); } + + // explainer-video's launcher runs only the Pythons its scripts/pydeps.json lists (3.12 and 3.13). + test("explainer-video: the python entry passes 3.13 and reports 3.14 outdated", () => { + const { manifest } = loadManifest(path.join(pluginsDir, "explainer-video")); + const python = manifest.requires.find((e) => e.id === "python"); + const at = (v) => + detectEntry(python, { env: { PATH: bin({ python3: `echo "Python ${v}"` }) }, platform: process.platform, cwd: work }); + assert.equal(at("3.13.5").status, "present"); + assert.equal(at("3.14.0").status, "outdated"); + }); }); describe("command line", () => { diff --git a/plugins/explainer-video/prerequisites.json b/plugins/explainer-video/prerequisites.json index 43386101203..965c34700ce 100644 --- a/plugins/explainer-video/prerequisites.json +++ b/plugins/explainer-video/prerequisites.json @@ -17,7 +17,7 @@ "for": ["hook:install-python-deps.sh", "skill:produce", "skill:check"], "detect": { "any": ["python3.13", "python3.12", "python3", "python"], - "version": { "args": ["--version"], "pattern": "Python ([0-9.]+)", "min": "3.12" } + "version": { "args": ["--version"], "pattern": "Python ([0-9.]+)", "min": "3.12", "below": "3.14" } }, "degrade": "Without Python 3.12 or 3.13 ManimCE is not installed and /explainer-video:produce cannot render. Python 3.14 is not supported.", "install": { "docs": "https://www.python.org/downloads/", "brew": "python@3.13", "winget": "Python.Python.3.13", "apt": "python3.13" },