Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ghosthamlet/lessphp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: leafo/lessphp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 19 files changed
  • 9 contributors

Commits on Oct 15, 2018

  1. tests: Drop PHP 5.3 from matrix, add PHP 7

    PHP 5.3 is EOL, and composer no longer supports it.
    
    For Travis CI, the build is also failing outstanding PRs due to
    PHP 5.3 requiring Ubuntu Precise (also EOL), whereas the
    default image uses uses Ubuntu Trusty.
    Krinkle authored Oct 15, 2018
    Configuration menu
    Copy the full SHA
    5549051 View commit details
    Browse the repository at this point in the history
  2. Update LICENSE

    * Remove outdated version (not needed).
    * Update year to last year of significant change or release
      by author.
    
    Closes leafo#603.
    paladox authored and Krinkle committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    d953e57 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2018

  1. Configuration menu
    Copy the full SHA
    0d4cfd9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed6e4d8 View commit details
    Browse the repository at this point in the history
  3. Correct typo in patternMatch() comment

    Closes leafo#601.
    kraftbj authored and Krinkle committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    601066e View commit details
    Browse the repository at this point in the history
  4. lessify: more portable shebang via 'env'

    Same as was done for 'plessc' in 8b6e7a7 (leafo#306).
    
    Closes leafo#610.
    rcano-miambiente authored and Krinkle committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    0b0dd10 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b63a8c4 View commit details
    Browse the repository at this point in the history
  6. Fix broken luma() implementation

    Two issues:
    
    * The formula was incomplete. This is now fixed.
    
    * The method was returning a float instead of a color array,
      which was used internally for lib_contrast, but was invalid
      as return value to the parser directly.
      The internal utility is now separate from lib_luma.
    
    As side-effect, this also fixes the following for PHP 7.1:
    > PHP Warning: A non-numeric value encountered
    
    Closes leafo#626.
    Krinkle committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    598c96a View commit details
    Browse the repository at this point in the history
  7. build: Remove PHP 7 from 'allow_failures'

    PHP 7.1, 7.2 and 7.3 are passing as of 598c96a.
    Krinkle committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    c77692e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4b18840 View commit details
    Browse the repository at this point in the history
  9. build: Add lessify binary to composer.json

    Fixes leafo#391.
    Closes leafo#540.
    cebe authored and Krinkle committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    e52c620 View commit details
    Browse the repository at this point in the history
  10. plessc: remove PHP close tag from

    Closes leafo#605.
    glensc authored and Krinkle committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    f65faed View commit details
    Browse the repository at this point in the history
  11. docs: Fix typo in example domain

    Duplicated TLD and trailing slash removal because the variable
    is used here: @{url}/bg.png so the url var should be: http://example.com
    instead of http://example.com.com/
    
    Closes leafo#566.
    Ecor authored and Krinkle committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    b89ac6a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    dcb1a8b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6ad7de0 View commit details
    Browse the repository at this point in the history
  14. tests: Apply PSR2 style for 'Generic.WhiteSpace.DisallowTabIndent'

    I'm already starting to regret this. Obviously, tabs are the only
    correct way of indenting code. But alas, PSR2 disagrees and being
    different makes the code harder to deal with for those familiar
    with PSR2.
    
    I'd be fine with switching to a different popular style preset,
    but we shouldn't have our own mix of PSR2 and something else,
    so for let's just go all-in on PSR2.
    Krinkle committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    cffe518 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e8f652f View commit details
    Browse the repository at this point in the history
  16. tests: Require PHP 5.6 or later (drop PHP 5.4 and PHP 5.5)

    Per <https://secure.php.net/eol.php>
    and <https://secure.php.net/supported-versions.php>.
    
    Also because PHPUnit 4.x is on longer supported by upstream.
    
    Ref MarcusSchwarz@cfdd1e2b27.
    Krinkle committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    18b8f29 View commit details
    Browse the repository at this point in the history
  17. license: Restore space between year and attribution

    Follows-up d953e57. Sorry!
    Krinkle committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    1fdc40e View commit details
    Browse the repository at this point in the history
Loading