Repository navigation
feat: pre batch creating TensorboardRuns and TensorboardTimeSeries in one_shot mode to speed up uploading - #772
Merged
Merged
Conversation
karthikv2k
self-requested a review
October 14, 2021 23:35
karthikv2k
approved these changes
Oct 15, 2021
sasha-gitg
requested changes
Oct 18, 2021
sasha-gitg
approved these changes
Oct 20, 2021
added 2 commits
October 20, 2021 14:11
… one_shot mode to speed up uploading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing uploader iterates through the log dir and creates TensorboardRun and TensorboardTimeSeries on demand, one at a time, which slows down the uploading quite a bit.
This PR seeks to improve the one_shot performance by iterating through the log dir first, collects the Runs and TimeSeries ahead of time, batch create ahead of time so fewer RPCs are sent.