-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Expand file tree
/
Copy pathtest.py
More file actions
224 lines (177 loc) · 4.06 KB
/
test.py
File metadata and controls
224 lines (177 loc) · 4.06 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
# Not OK
def simple(l = [0]):
l[0] = 1 # $ modification=l
return l
# Not OK
def slice(l = [0]):
l[0:1] = 1 # $ modification=l
return l
# Not OK
def list_del(l = [0]):
del l[0] # $ modification=l
return l
# Not OK
def append_op(l = []):
l += [1, 2, 3] # $ modification=l
return l
# Not OK
def repeat_op(l = [0]):
l *= 3 # $ modification=l
return l
# Not OK
def append(l = []):
l.append(1) # $ modification=l
return l
# OK
def includes(l = []):
x = [0]
x.extend(l)
x.extend([1])
return x
def extends(l):
l.extend([1]) # $ modification=l
return l
# Not OK
def deferred(l = []):
extends(l)
return l
# Not OK
def nonempty(l = [5]):
l.append(1) # $ modification=l
return l
# Not OK
def dict(d = {}):
d['a'] = 1 # $ modification=d
return d
# Not OK
def dict_nonempty(d = {'a': 1}):
d['a'] = 2 # $ modification=d
return d
# OK
def dict_nonempty_nochange(d = {'a': 1}):
d['a'] = 1 # $ SPURIOUS: modification=d
return d
def modifies(d):
d['a'] = 1 # $ modification=d
return d
# Not OK
def dict_deferred(d = {}):
modifies(d)
return d
# Not OK
def dict_method(d = {}):
d.update({'a': 1}) # $ modification=d
return d
# Not OK
def dict_method_nonempty(d = {'a': 1}):
d.update({'a': 2}) # $ modification=d
return d
# OK
def dict_method_nonempty_nochange(d = {'a': 1}):
d.update({'a': 1}) # $ SPURIOUS:modification=d
return d
def modifies_method(d):
d.update({'a': 1}) # $ modification=d
return d
# Not OK
def dict_deferred_method(d = {}):
modifies_method(d)
return d
# OK
def dict_includes(d = {}):
x = {}
x.update(d)
x.update({'a': 1})
return x
# Not OK
def dict_del(d = {'a': 1}):
del d['a'] # $ modification=d
return d
# Not OK
def dict_update_op(d = {}):
x = {'a': 1}
d |= x # $ modification=d
return d
# OK
def dict_update_op_nochange(d = {}):
x = {}
d |= x # $ SPURIOUS: modification=d
return d
def sanitizer(l = []):
if l:
l.append(1)
else:
l.append(1) # $ modification=l
return l
def sanitizer_negated(l = [1]):
if not l:
l.append(1)
else:
l.append(1) # $ modification=l
return l
def sanitizer(l = []):
if not l:
l.append(1) # $ modification=l
else:
l.append(1)
return l
def sanitizer_negated(l = [1]):
if l:
l.append(1) # $ modification=l
else:
l.append(1)
return l
# indirect modification of parameter with default
def aug_assign_argument(x):
x += ['x'] # $ modification=x
def mutate_argument(x):
x.append('x') # $ modification=x
def indirect_modification(y = []):
aug_assign_argument(y)
mutate_argument(y)
def guarded_modification(z=[]):
if z:
z.append(0)
return z
# This function causes a discrepancy between the
# Python 2 and 3 versions of the analysis.
# We comment it out until we have resoved the issue.
#
# def issue1143(expr, param=[]):
# if not param:
# return result
# for i in param:
# param.remove(i) # Mutation here
# Type guarding of modification of parameter with default:
def do_stuff_based_on_type(x):
if isinstance(x, str):
x = x.split()
elif isinstance(x, dict):
x.setdefault('foo', 'bar') # $ modification=x
elif isinstance(x, list):
x.append(5) # $ modification=x
elif isinstance(x, tuple):
x = x.unknown_method()
def str_default(x="hello world"):
do_stuff_based_on_type(x)
def dict_default(x={'baz':'quux'}):
do_stuff_based_on_type(x)
def list_default(x=[1,2,3,4]):
do_stuff_based_on_type(x)
def tuple_default(x=(1,2)):
do_stuff_based_on_type(x)
# Modification of parameter with default (safe method)
def safe_method(x=[]):
return x.count(42)
# Use of deepcopy:
from copy import deepcopy
def flow_from_within_deepcopy_fp():
y = deepcopy([])
y.append(1)
def flow_through_deepcopy_fp(x=[]):
y = deepcopy(x)
y.append(1)
# Use of copy method:
def flow_through_copy_fp(x=[]):
y = x.copy()
y.append(1)