codeql/java/ql/test/experimental/query-tests/security/CWE-347/JwtNoVerifier.java at main · github/codeql · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
import java.io.*;
import java.security.NoSuchAlgorithmException;
import java.util.Objects;
import java.util.Optional;
import javax.crypto.KeyGenerator;
import javax.servlet.http.*;
import javax.servlet.annotation.*;

import com.auth0.jwt.JWT;
import com.auth0.jwt.JWTVerifier;
import com.auth0.jwt.algorithms.Algorithm;
import com.auth0.jwt.exceptions.JWTVerificationException;
import com.auth0.jwt.interfaces.DecodedJWT;
import org.apache.shiro.authc.AuthenticationToken;
import org.apache.shiro.authc.BearerToken;

public class JwtNoVerifier extends HttpServlet {

    public void doPost(HttpServletRequest request, HttpServletResponse response) throws IOException {
        response.setContentType("text/html");
        PrintWriter out = response.getWriter();

        // OK: first decode without signature verification
        // and then verify with signature verification
        String JwtToken1 = request.getParameter("JWT1");
        String userName = decodeToken(JwtToken1);
        verifyToken(JwtToken1, "A Securely generated Key");
        if (Objects.equals(userName, "Admin")) {
            out.println("<html><body>");
            out.println("<h1>" + "heyyy Admin" + "</h1>");
            out.println("</body></html>");
        }

        out.println("<html><body>");
        out.println("<h1>" + "heyyy Nobody" + "</h1>");
        out.println("</body></html>");
    }

    public void doGet(HttpServletRequest request, HttpServletResponse response) throws IOException {
        response.setContentType("text/html");
        PrintWriter out = response.getWriter();

        // NOT OK:  only decode, no verification
        String JwtToken1 = request.getParameter("JWT2"); // $ Source
        String userName = decodeToken(JwtToken1);
        if (Objects.equals(userName, "Admin")) {
            out.println("<html><body>");
            out.println("<h1>" + "heyyy Admin" + "</h1>");
            out.println("</body></html>");
        }

        AuthenticationToken authToken = new BearerToken("admin", "admin");
        // OK:  no clue of the use of unsafe decoded JWT return value
        String JwtToken2 = request.getParameter("JWT2");
        JWT.decode(JwtToken2);

        // NOT OK:  only decode, no verification
        String JwtToken3 = (String) authToken.getCredentials(); // $ Source
        userName = decodeToken(JwtToken3);
        if (Objects.equals(userName, "Admin")) {
            out.println("<html><body>");
            out.println("<h1>" + "heyyy Admin" + "</h1>");
            out.println("</body></html>");
        }

        // OK:  no clue of the use of unsafe decoded JWT return value
        String JwtToken4 = (String) authToken.getCredentials();
        JWT.decode(JwtToken4);


        out.println("<html><body>");
        out.println("<h1>" + "heyyy Nobody" + "</h1>");
        out.println("</body></html>");
    }

    public static boolean verifyToken(final String token, final String key) {
        try {
            JWTVerifier verifier = JWT.require(Algorithm.HMAC256(key)).build();
            verifier.verify(token);
            return true;
        } catch (JWTVerificationException e) {
            System.out.printf("jwt decode fail, token: %s", e);
        }
        return false;
    }


    public static String decodeToken(final String token) {
        DecodedJWT jwt = JWT.decode(token);
        return Optional.of(jwt).map(item -> item.getClaim("userName").asString()).orElse(""); // $ Alert
    }


    private static String getSecureRandomKey() throws NoSuchAlgorithmException {
        KeyGenerator keyGen = KeyGenerator.getInstance("AES");
        keyGen.init(256); // for example
        return keyGen.generateKey().toString();
    }

    static final String JWT_KEY = "KEY";

    public static void NoNeedForTest(HttpServletRequest request) {
        // constant key
        String JwtToken3 = request.getParameter("JWT3");
        verifyToken(JwtToken3, JWT_KEY);

        // none algorithm
        String JwtToken4 = request.getParameter("JWT4");
        try {
            verifyTokenNoneAlg(JwtToken4, getSecureRandomKey());
        } catch (NoSuchAlgorithmException e) {
            throw new RuntimeException(e);
        }

    }

    public static String generateToken(final String userName, final String key) {
        try {
            return JWT.create().withClaim("userName", userName).sign(Algorithm.HMAC256(key));
        } catch (IllegalArgumentException e) {
            System.out.printf("JWTToken generate fail %s", e);
        }
        return "";
    }

    public static boolean verifyTokenNoneAlg(final String token, final String key) {
        try {
            JWTVerifier verifier = JWT.require(Algorithm.none()).build();
            verifier.verify(token);
            return true;
        } catch (JWTVerificationException e) {
            System.out.printf("jwt decode fail, token: %s", e);
        }
        return false;
    }
}