-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Expand file tree
/
Copy pathtst.js
More file actions
191 lines (174 loc) · 3.93 KB
/
tst.js
File metadata and controls
191 lines (174 loc) · 3.93 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
// update variants
React.createClass({
render: function() {
this.setState({}); // $ Alert
this.replaceState({}); // $ Alert
this.forceUpdate({}); // $ Alert
return <div/>
}
});
// indirect call, in ES6 class
class MyClass1 extends React.Component {
constructor(props) {
super(props);
}
render() {
this.indirectUpdate(); // $ Alert
this.veryIndirectUpdate(); // $ Alert
return <div/>
}
indirectUpdate() {
this.setState({});
}
veryIndirectUpdate() {
this.lessIndirectUpdate();
}
lessIndirectUpdate() {
this.setState({});
}
}
// definiteness variants
React.createClass({
render: function() {
this.setState({}); // $ Alert
},
componentDidUpdate: function() {
this.setState({}); // $ Alert
if (cond) {
this.setState({});
}
},
shouldComponentUpdate: function() {
this.setState({}); // $ Alert
if (cond) {
this.setState({});
}
},
componentWillUpdate: function() {
this.setState({}); // $ Alert
if (cond) {
this.setState({});
}
}
});
// definiteness and indirect call, in ES6 class
class MyClass2 extends React.Component {
constructor(props) {
super(props);
}
componentWillUpdate() {
this.definiteIndirectUpdate(); // $ Alert
if (cond) {
this.definiteIndirectUpdate();
}
this.indefiniteIndirectUpdate();
return <div/>
}
definiteIndirectUpdate() {
this.setState({});
}
indefiniteIndirectUpdate() {
if (cond) {
this.setState({});
}
}
}
// aliasing
React.createClass({
render: function() {
var app = this;
app.setState({}); // $ Alert
return <div/>
}
});
// indirect, in object literal
React.createClass({
indirectUpdate: function() {
this.setState({})
},
render: function() {
this.indirectUpdate(); // $ Alert
return <div/>
}
});
// eslint examples
React.createClass({
componentDidUpdate: function() {
this.setState({
name: this.props.name.toUpperCase()
}); // $ Alert
},
render: function() {
return <div>Hello {this.state.name}</div>;
}
});
React.createClass({
componentWillUpdate: function() {
this.setState({
name: this.props.name.toUpperCase()
}); // $ Alert
},
render: function() {
return <div>Hello {this.state.name}</div>;
}
});
// Most SO examples: early invoked event handler
class Search extends React.Component {
constructor() {
super();
this.handleButtonChange = this.handleButtonChange.bind(this);
}
handleButtonChange() {
this.setState({});
}
render() {
return (
<Button onClick={this.handleButtonChange()} ></Button> // $ Alert
);
}
}
// less serious variants
class MyClass3 extends React.Component {
constructor(props) {
super(props);
this.setState({}); // $ Alert
}
componentDidUnmount() {
this.setState({}); // $ Alert
}
getDefaultProps() {
this.setState({}); // $ Alert
}
getInitialState() {
this.setState({}); // $ Alert
}
componentWillUnmount() {
this.setState({});
}
componentWillMount() {
this.setState({});
}
componentDidMount() {
this.setState({});
}
}
// arrow functions
class MyClass4 extends React.Component {
constructor(props) {
super(props);
}
myUpdate() {
this.setState();
}
render() {
var doUpdate1 = () => this.setState({});
var doUpdate2 = () => this.myUpdate();
var doUpdate3 = () => {
var doUpdate4 = () => this.myUpdate();
doUpdate4();
}
doUpdate1(); // $ Alert
doUpdate2(); // $ Alert
doUpdate3(); // $ Alert
}
}