Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Treader/ImportExcel
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: dfinke/ImportExcel
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 4 files changed
  • 3 contributors

Commits on Oct 21, 2024

  1. Remove flagged URI

    Removed due to various AV's flagging the link as malicious thus flagging and quarentining the module.
    evenmartinsen authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a2bc50a View commit details
    Browse the repository at this point in the history
  2. Re-add icon variable (Commented)

    re-added variable for easier modification in the future.
    evenmartinsen authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5a61c5d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db84a59 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fb41d3d View commit details
    Browse the repository at this point in the history
  5. Merge pull request dfinke#1648 from evenmartinsen/master

    Remove flagged URL
    dfinke authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    85e48ac View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dc4a5e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2025

  1. Configuration menu
    Copy the full SHA
    49affcf View commit details
    Browse the repository at this point in the history
  2. move llms text to root

    dfinke committed Apr 11, 2025
    Configuration menu
    Copy the full SHA
    fa447a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2025

  1. [Get-HtmlTable] XPath optimization

    ```powershell
    $rows =    $h.SelectNodes("//table[$TableIndex]//tr")
    ```
    XPath selector in line 53 uses complex expression that can lead to unexpected result. The problem is that HtmlAgilityPack may have specific issues. In particular, on websites containing multiple tables this selector can find not one table. This is aggravated by the fact that tables can have different structures.
    To avoid ambiguity this PR suggests to separate queries. Oneliner simplifies error checking
    ```powershell
    $rows = try {
      $h.SelectSingleNode("//table[$TableIndex]").SelectNodes(".//tr")
    } catch {}
    if (-not $rows) {Write-Warning "Could not find rows for `"//table[$TableIndex]`" in $Url ."}
    ```
    This expression doesn't even need testing, it just works.
    scriptingstudio authored Apr 23, 2025
    Configuration menu
    Copy the full SHA
    45ed6a0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request dfinke#1695 from scriptingstudio/master

    [Get-HtmlTable] XPath optimization
    dfinke authored Apr 23, 2025
    Configuration menu
    Copy the full SHA
    5387c06 View commit details
    Browse the repository at this point in the history
Loading