Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: git/git
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: barrbrain/git
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: vcs-svn-housekeeping
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 8 files changed
  • 1 contributor

Commits on May 24, 2012

  1. vcs-svn: prefer constcmp to prefixcmp 

    Comparisons in svndump.c are always guarded by length.
As a bonus, elimate dependency on prefixcmp for upstream.

Signed-off-by: David Barr <davidbarr@google.com>
    @barrbrain
    barrbrain committed May 24, 2012
    Configuration menu
    Copy the full SHA
    e967d5f View commit details
    Browse the repository at this point in the history

  2. vcs-svn: prefer strstr over memmem 

    The common pattern is to use strstr to match a fixed needle.
As a bonus, elimate dependency on memmem for upstream.

Signed-off-by: David Barr <davidbarr@google.com>
    @barrbrain
    barrbrain committed May 24, 2012
    Configuration menu
    Copy the full SHA
    34973e7 View commit details
    Browse the repository at this point in the history

  3. vcs-svn: fix signedness warnings 

    Stop mixing off_t and size_t.

Signed-off-by: David Barr <davidbarr@google.com>
    @barrbrain
    barrbrain committed May 24, 2012
    Configuration menu
    Copy the full SHA
    7912a84 View commit details
    Browse the repository at this point in the history

  4. vcs-svn: drop no-op reset methods 

    Since v1.7.5~42^2~6 (vcs-svn: remove buffer_read_string)
buffer_reset() does nothing thus fast_export_reset() also.

Signed-off-by: David Barr <davidbarr@google.com>
    @barrbrain
    barrbrain committed May 24, 2012
    Configuration menu
    Copy the full SHA
    5d68784 View commit details
    Browse the repository at this point in the history

  5. vcs-svn: fix cppcheck warning 

    [vcs-svn/fast_export.c:211]: (warning) Using sizeof with a numeric constant as function argument might not be what you intended.

Signed-off-by: David Barr <davidbarr@google.com>
    @barrbrain
    barrbrain committed May 24, 2012
    Configuration menu
    Copy the full SHA
    b0e6e5b View commit details
    Browse the repository at this point in the history

  6. vcs-svn: fix clang-analyzer error 

    vcs-svn/svndiff.c:298:3: warning: Assigned value is garbage or undefined
                off_t pre_off = pre_off; /* stupid GCC... */
                ^               ~~~~~~~

Signed-off-by: David Barr <davidbarr@google.com>
    @barrbrain
    barrbrain committed May 24, 2012
    Configuration menu
    Copy the full SHA
    1a8cbbf View commit details
    Browse the repository at this point in the history

  7. vcs-svn: fix clang-analyzer warning 

    vcs-svn/svndiff.c:278:3: warning: expression result unused [-Wunused-value]
                error("invalid delta: incorrect postimage length");
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from vcs-svn/svndiff.c:6:
vcs-svn/compat-util.h:18:61: note: instantiated from:
#define error(...) (fprintf(stderr, "error: " __VA_ARGS__), -1)
                                                            ^~

Signed-off-by: David Barr <davidbarr@google.com>
    @barrbrain
    barrbrain committed May 24, 2012
    Configuration menu
    Copy the full SHA
    e067cb9 View commit details
    Browse the repository at this point in the history
Loading