Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/PathPicker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ashed/PathPicker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 5 files changed
  • 5 contributors

Commits on Oct 3, 2019

  1. Update README.md

    @akshayakshay30
    akshayakshay30 authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    c981bef View commit details
    Browse the repository at this point in the history

  2. Merge pull request #308 from akshayakshay30/patch-1 

    Update gramatical mistake README.md
    @pcottle
    pcottle authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    791bdd7 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Fix simple typo: tricy -> tricky 

    Closes #310
    @timgates42
    timgates42 committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    40532a0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #311 from timgates42/bugfix/typo_tricky 

    Fix simple typo: tricy -> tricky
    @pcottle
    pcottle authored Dec 4, 2019
    Configuration menu
    Copy the full SHA
    3009456 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Change path of output file to match debian standard 

    The standard debian filename of a package is
PACKAGENAME_VERSION_ARCH.deb. Therefore, ideally it should be named
pathpicker_0.9.2_all.deb. In the Debian manual at
https://www.debian.org/doc/manuals/debian-faq/pkg-basics.en.html#pkgname,
it says:

    The Debian binary package file names conform to the following
    convention: <foo>_<VersionNumber>-<DebianRevisionNumber>_<DebianArchitecture>.deb

This currently adds an extra step before we can add it to our local repo
so it would be nice if this output the expected filename.
    @ssgelm
    ssgelm committed May 20, 2020
    Configuration menu
    Copy the full SHA
    53457d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. add FB used repos 

    at FB, those are commonly used repos;
    @dragonxlwang
    dragonxlwang authored Jun 5, 2020
    Configuration menu
    Copy the full SHA
    905f801 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2020

  1. allow change REPOS by environment variables 

    1 liner, and this is to allow customize repos; Either this or #314 can be used to unblock; Thanks
    @dragonxlwang
    dragonxlwang authored Jun 6, 2020
    Configuration menu
    Copy the full SHA
    4372fb2 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Merge pull request #315 from dragonxlwang/patch-2 

    allow change REPOS by environment variables
    @pcottle
    pcottle authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    30182fa View commit details
    Browse the repository at this point in the history

  2. Merge pull request #314 from dragonxlwang/patch-1 

    add FB used repos
    @pcottle
    pcottle authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    23b7980 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #313 from ssgelm/fix_deb_name 

    Change path of output file to match debian standard
    @pcottle
    pcottle authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    8736fc7 View commit details
    Browse the repository at this point in the history
Loading