From a88e136aeee7aa6a1e054e4692aef12d9db16168 Mon Sep 17 00:00:00 2001
From: vikramvee <vikram.vee@outlook.com>
Date: Sat, 21 Jan 2023 22:51:43 +0530
Subject: [PATCH 1/2] Removed the use of String Literals

---
 FactoryPattern/Helper.cs | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 FactoryPattern/Helper.cs

diff --git a/FactoryPattern/Helper.cs b/FactoryPattern/Helper.cs
new file mode 100644
index 0000000..4a897e8
--- /dev/null
+++ b/FactoryPattern/Helper.cs
@@ -0,0 +1,18 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace FactoryPattern
+{
+    internal class Helper
+    {
+    }
+
+    internal enum PizzaType
+    {
+        Cheese,
+        Clam
+    }
+}

From 7f956c3cc7ebd68f90648121bd56402be666652f Mon Sep 17 00:00:00 2001
From: vikramvee <vikram.vee@outlook.com>
Date: Sat, 21 Jan 2023 22:56:30 +0530
Subject: [PATCH 2/2] Removed the use of String Literals for clean code

---
 .../Factory Method/ChicagoPizzaFactory.cs        | 16 ++++++++++------
 FactoryPattern/Factory Method/NYPizzaFactory.cs  | 16 ++++++++++------
 FactoryPattern/Factory Method/PizzaFactory.cs    |  4 ++--
 FactoryPattern/Program.cs                        |  4 ++--
 4 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/FactoryPattern/Factory Method/ChicagoPizzaFactory.cs b/FactoryPattern/Factory Method/ChicagoPizzaFactory.cs
index 2075587..234bdb0 100644
--- a/FactoryPattern/Factory Method/ChicagoPizzaFactory.cs	
+++ b/FactoryPattern/Factory Method/ChicagoPizzaFactory.cs	
@@ -2,25 +2,29 @@
 {
     class ChicagoPizzaFactory : PizzaFactory
     {
-        protected override Pizza Create(string type)
+        private readonly string chicagoCheese = "Chicago Cheese";
+        private readonly string chicagoClam = "Chicago Clam";
+        private readonly string chicagoVeggie = "Chicago Veggie";
+
+        protected override Pizza Create(PizzaType type)
         {
             Pizza pizza;
             IIngredientsFactory ingredients = new ChicagoIngredientsFactory();
 
-            if (type.Equals("Cheese"))
+            if (type == PizzaType.Cheese)
             {
                 pizza = new CheesePizza(ingredients);
-                pizza.Name = "Chicago Cheese";
+                pizza.Name = chicagoCheese;
             }
-            else if (type.Equals("Clam"))
+            else if (type == PizzaType.Clam)
             {
                 pizza = new ClamPizza(ingredients);
-                pizza.Name = "Chicago Clam";
+                pizza.Name = chicagoClam;
             }
             else
             {
                 pizza = new VeggiePizza(ingredients);
-                pizza.Name = "Chicago Veggie";
+                pizza.Name = chicagoVeggie;
             }
             pizza.Color = "red";
             return pizza;
diff --git a/FactoryPattern/Factory Method/NYPizzaFactory.cs b/FactoryPattern/Factory Method/NYPizzaFactory.cs
index 2c24bff..de2d0b7 100644
--- a/FactoryPattern/Factory Method/NYPizzaFactory.cs	
+++ b/FactoryPattern/Factory Method/NYPizzaFactory.cs	
@@ -2,22 +2,26 @@
 {
     class NyPizzaFactory : PizzaFactory
     {
-        protected override Pizza Create(string type)
+        private readonly string nyStyleCheese = "NY Style Cheese";
+        private readonly string nyStyleClam = "NY Style Clam";
+        private readonly string nyStyleVeggie = "NY Style Veggie";
+
+        protected override Pizza Create(PizzaType type)
         {
             Pizza pizza;
             IIngredientsFactory ingredients = new NyIngredientsFactory();
 
-            if (type.Equals("Cheese"))
+            if (type == PizzaType.Cheese)
             {
-                pizza = new CheesePizza(ingredients) { Name = "NY Style Cheese" };
+                pizza = new CheesePizza(ingredients) { Name = nyStyleCheese };
             }
-            else if (type.Equals("Clam"))
+            else if (type == PizzaType.Clam)
             {
-                pizza = new ClamPizza(ingredients) { Name = "NY Style Clam" };
+                pizza = new ClamPizza(ingredients) { Name = nyStyleClam };
             }
             else
             {
-                pizza = new VeggiePizza(ingredients) { Name = "NY Style Veggie" };
+                pizza = new VeggiePizza(ingredients) { Name = nyStyleVeggie };
             }
             pizza.Color = "blue";
             return pizza;
diff --git a/FactoryPattern/Factory Method/PizzaFactory.cs b/FactoryPattern/Factory Method/PizzaFactory.cs
index 31ead68..f0b7a38 100644
--- a/FactoryPattern/Factory Method/PizzaFactory.cs	
+++ b/FactoryPattern/Factory Method/PizzaFactory.cs	
@@ -2,7 +2,7 @@
 {
     abstract class PizzaFactory
     {
-        public Pizza Order(string type)
+        public Pizza Order(PizzaType type)
         {
             var pizza = Create(type);
             pizza.Prepare();
@@ -12,6 +12,6 @@ public Pizza Order(string type)
             return pizza;
         }
 
-        protected abstract Pizza Create(string type);
+        protected abstract Pizza Create(PizzaType type);
     }
 }
diff --git a/FactoryPattern/Program.cs b/FactoryPattern/Program.cs
index d16bc6f..0612463 100644
--- a/FactoryPattern/Program.cs
+++ b/FactoryPattern/Program.cs
@@ -8,11 +8,11 @@ static void Main()
         {
             Console.WriteLine("Yankees fan orders:");
             var yankees = new NyPizzaFactory();
-            yankees.Order("Cheese");
+            yankees.Order(PizzaType.Cheese);
             Console.WriteLine();
             Console.WriteLine("Cubs fan orders:");
             var cubs = new ChicagoPizzaFactory();
-            cubs.Order("Clam");
+            cubs.Order(PizzaType.Clam);
         }
     }
 }
\ No newline at end of file