Skip to content

Added SumAsync#290

Merged
StefH merged 5 commits intozzzprojects:masterfrom
wertzui:master
Aug 24, 2019
Merged

Added SumAsync#290
StefH merged 5 commits intozzzprojects:masterfrom
wertzui:master

Conversation

@wertzui
Copy link
Copy Markdown
Contributor

@wertzui wertzui commented Aug 22, 2019

The SumAsync method was missing from the Entity Framework Core extension methods.

Copy link
Copy Markdown
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/Microsoft.EntityFrameworkCore.DynamicLinq/EFDynamicQueryableExtensions.cs Outdated
Copy link
Copy Markdown
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take a look at my comments

Comment thread src/Microsoft.EntityFrameworkCore.DynamicLinq/EFDynamicQueryableExtensions.cs Outdated
@StefH
Copy link
Copy Markdown
Collaborator

StefH commented Aug 22, 2019

Also add a new test file EntitiesTests.Sum.cs to test this new code.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 23, 2019

Codecov Report

Merging #290 into master will decrease coverage by 0.24%.
The diff coverage is 71.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage    87.5%   87.25%   -0.25%     
==========================================
  Files          42       42              
  Lines        4280     4324      +44     
==========================================
+ Hits         3745     3773      +28     
- Misses        535      551      +16
Impacted Files Coverage Δ
...rkCore.DynamicLinq/EFDynamicQueryableExtensions.cs 72.86% <71.73%> (-0.04%) ⬇️
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2393949...96fde3e. Read the comment docs.

@StefH
Copy link
Copy Markdown
Collaborator

StefH commented Aug 23, 2019

@wertzui Can you maybe add a SumAsync exmple to https://github.com/StefH/System.Linq.Dynamic.Core/blob/master/src-console/ConsoleAppEF1.1/Program.cs ? In that way you can be sure that this works for NETCore 1.x

@StefH StefH merged commit 8708ef8 into zzzprojects:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants